Fix gradient checkpointing issue for Stable Diffusion 3 #8542
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2024
|
Thank you! Ran into the same issue. |
|
can this fix my issue? #8545 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
can you run make style? |
There were no changes from that command to the one file that this modifies. |
|
The failed test is the same that I have, so need to wait for #8563 to be able to continue with the tests. |
yiyixuxu
added a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gradient checkpointing is enabled for SD3, in the example dreambooth script with default arguments, various modules fail with "expected Tensor, not tuple". This is because the gradient checkpointing codepath doesn't deconstruct the hidden states tuple. This fixes that issue.
@sayakpaul