[LoRA] pop the LoRA scale so that it doesn't get propagated to the weeds #7338
+9
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Mar 15, 2024
Comment on lines
-1091
to
-1100
| cross_attention_kwargs (`dict`, *optional*): | ||
| A kwargs dictionary that if specified is passed along to the [`AttnProcessor`]. | ||
| added_cond_kwargs: (`dict`, *optional*): | ||
| A kwargs dictionary containin additional embeddings that if specified are added to the embeddings that | ||
| are passed along to the UNet blocks. | ||
| down_block_additional_residuals (`tuple` of `torch.Tensor`, *optional*): | ||
| additional residuals to be added to UNet long skip connections from down blocks to up blocks for | ||
| example from ControlNet side model(s) | ||
| mid_block_additional_residual (`torch.Tensor`, *optional*): | ||
| additional residual to be added to UNet mid block output, for example from ControlNet side model |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
changed the title
| # we're popping the `scale` instead of getting it because otherwise `scale` will be propagated | ||
| # to the internal blocks and will raise deprecation warnings. this will be confusing for our users. | ||
| if cross_attention_kwargs is not None and "scale" in cross_attention_kwargs: | ||
| lora_scale = cross_attention_kwargs.pop("scale", 1.0) |
There was a problem hiding this comment.
If "scale" in cross_attention_kwargs, we don't need a default for pop, right?
yiyixuxu
reviewed
Mar 18, 2024
|
@yiyixuxu do you want me to do a patch release for this as this way the users won't get confused. |
|
@sayakpaul sure
|
|
Cool, I will take care of it. |
Co-authored-by: YiYi Xu <yixu310@gmail.com>
sayakpaul
added a commit
that referenced
this pull request
Mar 19, 2024
…eds (#7338) * pop scale from the top-level unet instead of getting it. * improve readability. * Apply suggestions from code review Co-authored-by: YiYi Xu <yixu310@gmail.com> * fix a little bit. --------- Co-authored-by: YiYi Xu <yixu310@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The changes should be self-explanatory. But let me know in case of any explanation.
I think we should maybe do a patch release for this.