Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CogVideoX LoRA fuse test #10352

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix failing CogVideoX LoRA fuse test #10352

merged 2 commits into from
Dec 23, 2024

Conversation

a-r-r-o-w
Copy link
Member

Context: https://huggingface.slack.com/archives/C065E480NN9/p1734937335392109?thread_ts=1734935953.846629&cid=C065E480NN9

Fixes test: https://github.com/huggingface/diffusers/actions/runs/12461857058/job/34781970659#step:6:6623

This went uncaught in #10270 because it only happens when .to() is not called on a pipeline, or torch_dtype is not specified while loading transformer component. The failing lora test does neither, so the alternative branch of code was never tested.

pos_embedding is torch.int64, which casts embeds to torch.int64 as well unless casted correctly in both branches

fix
@a-r-r-o-w a-r-r-o-w requested review from DN6 and sayakpaul December 23, 2024 07:51
@sayakpaul
Copy link
Member

I know you have run the concerned test on a GPU but just double-checking.

@a-r-r-o-w
Copy link
Member Author

Yep

image

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 DN6 merged commit 055d955 into main Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants