Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ndjson data files #7154

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Support ndjson data files #7154

merged 3 commits into from
Sep 19, 2024

Conversation

albertvillanova
Copy link
Member

Support ndjson (Newline Delimited JSON) data files.

Fix #7153.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to support it.

But note that it's a dead project; its author recommends using jsonlines: ndjson/ndjson-spec#35 (comment). Maybe something to add as a comment in the code

@albertvillanova
Copy link
Member Author

Thanks for your review, @severo.

Yes, I was aware of this. From internal conversation:

Please note that although NDJSON was planned to be submitted as an RFC standard spec, it is no longer maintained:

The purpose of this PR is just supporting datasets with ndjson data files (e.g. Wikimedia Enterprise data files), but it should not imply any recommendation or endorsement of this format from our part.

@albertvillanova albertvillanova merged commit 13f18e3 into main Sep 19, 2024
15 checks passed
@albertvillanova albertvillanova deleted the fix-7153 branch September 19, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support data files with .ndjson extension
3 participants