Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turbo_frame_tag with arrary argument regression #503

Closed
jcoyne opened this issue Oct 16, 2023 · 1 comment · Fixed by #504
Closed

turbo_frame_tag with arrary argument regression #503

jcoyne opened this issue Oct 16, 2023 · 1 comment · Fixed by #504

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Oct 16, 2023 •
edited 

<%= turbo_frame_tag [@term_hour.location_id, @term_hour.term.to_param, params[:day_of_week]] do %>

With 1.4.0:

<turbo-frame id="1_1_sunday">

With 1.5.0:

<turbo-frame id="1 1 sunday">

It seems like #476 broke this behavior.
@jcoyne jcoyne mentioned this issue Oct 16, 2023
Merged
jcoyne added a commit to jcoyne/turbo-rails that referenced this issue Oct 16, 2023
@jcoyne
Support for multiple string arguments to frame helper
ca7e6c0 
This fixes a regression in 1.5.0

Fixes hotwired#503
jcoyne added a commit to jcoyne/turbo-rails that referenced this issue Oct 16, 2023
@jcoyne
Support for multiple string arguments to frame helper
f26b571 
This fixes a regression in 1.5.0

Fixes hotwired#503
jcoyne added a commit to jcoyne/turbo-rails that referenced this issue Oct 16, 2023
@jcoyne
Support for multiple string arguments to frame helper
ffcbafc 
This fixes a regression in 1.5.0

Fixes hotwired#503
seanpdoyle added a commit to seanpdoyle/turbo-rails that referenced this issue Oct 16, 2023
@seanpdoyle
Restore turbo_frame_tag support for Array arguments
aefdf47 
Closes [hotwired#503][]

When the positional arguments to `turbo_frame_tag` respond are
compatible with `dom_id` (they respond to `#to_key`), pass them to
`dom_id`, otherwise, check them individually.

This approach melds the behavior introduced in [hotwired#476][] with the
original support.

[hotwired#503]: hotwired#503
[hotwired#476]: hotwired#476
@seanpdoyle seanpdoyle mentioned this issue Oct 16, 2023
Closed
@seanpdoyle
Copy link
Contributor

seanpdoyle commented Oct 16, 2023 •
edited

Thank you for opening this issue! I've opened #505 to try and resolve it.

Edit: I'm sorry, I missed that you've opened #504. #504 is a simpler solution, so I'll close mine.

jcoyne added a commit to jcoyne/turbo-rails that referenced this issue Oct 16, 2023
@jcoyne
Support for multiple string arguments to frame helper
2e96620 
This fixes a regression in 1.5.0

Fixes hotwired#503
@dhh dhh closed this as completed in #504 Oct 17, 2023
dhh pushed a commit that referenced this issue Oct 17, 2023
@jcoyne
Support for multiple string arguments to frame helper (#504)
818d919 
This fixes a regression in 1.5.0

Fixes #503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jcoyne @seanpdoyle