-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only IPv4 for zeroconf in bluesound integration #140226
Use only IPv4 for zeroconf in bluesound integration #140226
Conversation
Hey there @thrawnarn, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I've marked this PR a draft, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
Change looks good. Thanks. It needs a test before we can merge. |
Thanks @LouisChrist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @LouisChrist 👍
../Frenck
* Use only ipv4 for zeroconf * Fix tests * Use only ip_address for ip version check * Add test * Reduce test
Proposed change
Ignore IPv6 addresses from zeroconf.
It seems that the devices got partial IPv6 support in a firmware update, but the API is only listening on the IPv4 address.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: