Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only IPv4 for zeroconf in bluesound integration #140226

Merged

Conversation

LouisChrist
Copy link
Contributor

Proposed change

Ignore IPv6 addresses from zeroconf.

It seems that the devices got partial IPv6 support in a firmware update, but the API is only listening on the IPv4 address.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
LouisChrist Louis Christ

Verified

This commit was signed with the committer’s verified signature.
LouisChrist Louis Christ
@home-assistant
Copy link

home-assistant bot commented Mar 9, 2025

Hey there @thrawnarn, mind taking a look at this pull request as it has been labeled with an integration (bluesound) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bluesound can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bluesound Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco added this to the 2025.3.2 milestone Mar 9, 2025
@frenck frenck marked this pull request as draft March 10, 2025 09:54
@frenck
Copy link
Member

frenck commented Mar 10, 2025

I've marked this PR a draft, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

Verified

This commit was signed with the committer’s verified signature.
LouisChrist Louis Christ
@LouisChrist LouisChrist marked this pull request as ready for review March 10, 2025 20:05
@bdraco
Copy link
Member

bdraco commented Mar 11, 2025

Change looks good. Thanks. It needs a test before we can merge.

@bdraco bdraco marked this pull request as draft March 11, 2025 04:30
@frenck frenck modified the milestones: 2025.3.2, 2025.3.3 Mar 11, 2025

Verified

This commit was signed with the committer’s verified signature.
LouisChrist Louis Christ

Verified

This commit was signed with the committer’s verified signature.
LouisChrist Louis Christ
@LouisChrist LouisChrist marked this pull request as ready for review March 11, 2025 21:55
@bdraco
Copy link
Member

bdraco commented Mar 11, 2025

Thanks @LouisChrist

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LouisChrist 👍

../Frenck

@frenck frenck merged commit d952e81 into home-assistant:dev Mar 14, 2025
34 checks passed
frenck pushed a commit that referenced this pull request Mar 14, 2025

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
frenck’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
* Use only ipv4 for zeroconf

* Fix tests

* Use only ip_address for ip version check

* Add test

* Reduce test
@frenck frenck mentioned this pull request Mar 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
@LouisChrist LouisChrist deleted the bluesound_use_only_ipv4_for_zeroconf branch March 19, 2025 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants