Delete subscription on shutdown of SmartThings #140135
Merged
+275
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: smartthings
small-pr
balloob
reviewed
Mar 8, 2025
balloob
reviewed
Mar 8, 2025
joostlek
changed the title
frenck
approved these changes
Mar 11, 2025
frenck
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Cache subscription url in SmartThings * Cache subscription url in SmartThings * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Bump pysmartthings to 2.7.1 * 2.7.2 --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Merged
frenck
added a commit
that referenced
this pull request
Mar 11, 2025
* Don't allow creating backups if Home Assistant is not running (#139499) * Don't allow creating backups if hass is not running * Revert "Don't allow creating backups if hass is not running" This reverts commit 1bf545e. * Set backup manager to idle only after Home Assistant has started * Update according to discussion, add tests * Add more test * Bump govee_ble to 0.43.1 (#139862) Bump govee_ble to 0.43.0 * Label emergency heat switch (#139872) * Add label to emergency heat switch * Use sentence case names Co-authored-by: Franck Nijhof <frenck@frenck.nl> --------- Co-authored-by: Franck Nijhof <frenck@frenck.nl> * Bump sense-energy lib to 0.13.7 (#140068) * Update jinja to 3.1.6 (#140069) * Update evohome-async to 1.0.3 (#140083) bump client to 1.0.3 * Fix HEOS discovery error when previously ignored (#140091) Abort ignored discovery * Map prewash job state in SmartThings (#140097) * Check support for thermostat operating state in SmartThings (#140103) * Handle None options in SmartThings (#140110) * Handle None options in SmartThings * Handle None options in SmartThings * Fix MQTT JSON light not reporting color temp status if color is not supported (#140113) * Fix HEOS user initiated setup when discovery is waiting confirmation (#140119) * Support null supported Thermostat modes in SmartThings (#140101) * Set device class for Oven Completion time in SmartThings (#140139) * Revert "Check if the unit of measurement is valid before creating the entity" (#140155) Revert "Check if the unit of measurement is valid before creating the entity …" This reverts commit 99e1a7a. * Fix the order of the group members attribute of the Music Assistant integration (#140204) * Fix events without user in Bring integration (#140213) Fix events without publicUserUuid * Log broad exception in Electricity Maps config flow (#140219) * Bump evohome-async to 1.0.4 to fix #140194 (#140230) bump client, add test for fix #140194 * Refresh Home Connect token during config entry setup (#140233) * Refresh token during config entry setup * Test 500 error --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Add 900 RPM option to washer spin speed options at Home Connect (#140234) Add 900 RPM option to washer spin speed options * Fix todo tool broken with Gemini 2.0 models. (#140246) * Change tool name for addlist item * Change to HasListAddItem * extract to function * Fix version not always available in onewire (#140260) * Fix `client_id` not generated when connecting to the MQTT broker (#140264) Fix client_id not generated when connecting to the MQTT broker * Bump velbusaio to 2025.3.0 (#140267) * Fix dryer operating state in SmartThings (#140277) * FGLair : Upgrade to ayla-iot-unofficial 1.4.7 (#140296) Upgrade to ayla-iot-unofficial 1.4.7 * Bump pyheos to v1.0.3 (#140310) Bump pyheos v1.0.3 * Bump ZHA to 0.0.52 (#140325) * Bump pydrawise to 2025.3.0 (#140330) * Bump teslemetry-stream (#140335) Bump * Fix no temperature unit in SmartThings (#140363) * Fix double space quoting in WebDAV (#140364) * Bump python-roborock to 2.12.2 (#140368) bump python roboorck to 2.12.2 * Handle incomplete power consumption reports in SmartThings (#140370) * Fix browsing Audible Favorites in Sonos (#140378) * initial commit * updates * update test data * Make sure SmartThings light can deal with unknown states (#140190) * Fix * add comment * Make light unknown * Make light unknown * Delete subscription on shutdown of SmartThings (#140135) * Cache subscription url in SmartThings * Cache subscription url in SmartThings * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Fix * Bump pysmartthings to 2.7.1 * 2.7.2 --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Bump version to 2025.3.2 --------- Co-authored-by: Erik Montnemery <erik@montnemery.com> Co-authored-by: Evan Farrell <evan@evanfarrell.com> Co-authored-by: John Hillery <34005807+jrhillery@users.noreply.github.com> Co-authored-by: Keilin Bickar <TrumpetGod@gmail.com> Co-authored-by: David Bonnes <zxdavb@bonnes.me> Co-authored-by: Andrew Sayre <6730289+andrewsayre@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: msm595 <msm595@users.noreply.github.com> Co-authored-by: Manu <4445816+tr4nt0r@users.noreply.github.com> Co-authored-by: Jan-Philipp Benecke <jan-philipp@bnck.me> Co-authored-by: J. Diego Rodríguez Royo <jdrr1998@hotmail.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Luke Lashley <conway220@gmail.com> Co-authored-by: epenet <6771947+epenet@users.noreply.github.com> Co-authored-by: Maikel Punie <maikel.punie@gmail.com> Co-authored-by: Antoine Reversat <a.reversat@gmail.com> Co-authored-by: puddly <32534428+puddly@users.noreply.github.com> Co-authored-by: David Knowles <dknowles2@gmail.com> Co-authored-by: Brett Adams <Bre77@users.noreply.github.com> Co-authored-by: Pete Sage <76050312+PeteRager@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
So SmartThings currently has an issue where we create too many subscriptions, and SmartThings now has a limit on the concurrent subscriptions. So we agreed on deleting the old subscription when we shut down. We currently also store and sync the subscription id in the config entry data, so if we then have the problem that we can't delete the subscription because there's no internet or power got cut off abruptly, we can still delete it on boot, making sure a single instance always keeps a single subscription
pySmartThings/pysmartthings@v2.7.0...v2.7.2
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: