Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HEOS discovery error when previously ignored #140091

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

andrewsayre
Copy link
Member

Proposed change

The HEOS discovery flow does not properly handle the scenario where discovery was previously ignored and the config entry data is not populated. This results in an unhandled exception that gets logged at startup. This change properly handles previously ignored discovery. Test has been added to cover this scenario.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
boesing Maximilian Bösing
@andrewsayre andrewsayre added this to the 2025.3.2 milestone Mar 8, 2025
@andrewsayre andrewsayre changed the title Fix HEOS discovery unahndled error when previously ignored Fix HEOS discovery error when previously ignored Mar 8, 2025
@balloob balloob merged commit deea19d into dev Mar 8, 2025
33 checks passed
@balloob balloob deleted the fix_heos_ignored_discovery branch March 8, 2025 04:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEOS error in log, and cannot install integration either
3 participants