Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure script llm tool name does not start with a digit #122349

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Jul 22, 2024

Proposed change

Fixes the following error with google_generative_ai_conversation:

ERROR (MainThread) [homeassistant.components.google_generative_ai_conversation] Error sending message: <class 'google.api_core.exceptions.InvalidArgument'> 400 * GenerateContentRequest.tools[0].function_declarations[3].name: Invalid function name. Must start with a letter or an underscore. Must be alphameric (a-z, A-Z, 0-9), underscores (_), dots (.) or dashes (-), with a maximum length of 64.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Shulyaka Denis Shulyaka
@Shulyaka Shulyaka marked this pull request as ready for review July 22, 2024 01:01
@Shulyaka Shulyaka requested a review from a team as a code owner July 22, 2024 01:01

Verified

This commit was signed with the committer’s verified signature.
Shulyaka Denis Shulyaka
@joostlek joostlek added this to the 2024.7.4 milestone Jul 22, 2024
@joostlek joostlek merged commit 064d726 into home-assistant:dev Jul 22, 2024
36 checks passed
@Shulyaka Shulyaka deleted the script_tool_name branch July 22, 2024 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Generative AI returns "400 bad request" on system control prompt
3 participants