-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support backup of add-ons with hyphens #115274
Conversation
The Supervisor allows add-ons to use hyphens in their slug. Allows backup and restore service calls to use add-on names with hyphens. As there is no simple way to check slugs with hyphens, simply use string validation instead. Fixes: #107693
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
The slugify function do use So we can either state in all documentation and in config validation that slug must be separated by The validation of SLUG for supervisor is a regex where hyphen is allowed https://github.com/home-assistant/supervisor/blob/501c9579fb87f036c363fd70f0acfe3b70899ecd/supervisor/addons/const.py#L48 |
codecov should be fixed now |
influx db test failure is a flakey test. I attempted to fix it in #115442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @agners 👍
../Frenck
Co-authored-by: J. Nick Koston <nick@koston.org>
Breaking change
Proposed change
The Supervisor allows add-ons to use hyphens in their slug. This change allows backup and restore service calls to use add-on names with hyphens. Use the existing regex validator to validate add-on slugs.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: