Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure platform setup for all AVM FRITZ!SmartHome devices #105515

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Dec 11, 2023

Proposed change

In case when one platform setup is delayed (example #105346 (comment)) the coordinator.new_devices might already be cleared by a meanwhile further coordinator data update run.
To ensure each platform is at proper set up, we statically run _add_entities with the whole bunch of devices during setup, but during coordinator update listener, we only consider the coordinator.new_devices property.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mib1185 mib1185 added this to the 2023.12.2 milestone Dec 11, 2023
@mib1185 mib1185 requested a review from elupus December 12, 2023 22:27
@mib1185
Copy link
Contributor Author

mib1185 commented Dec 12, 2023

Hi @elupus sorry to "bother" you with this PR, but it is a fix for #103859 where we had worked together on it.

@frenck frenck modified the milestones: 2023.12.2, 2023.12.3 Dec 13, 2023
@mib1185 mib1185 requested a review from elupus December 13, 2023 16:27
@mib1185 mib1185 merged commit 08ca367 into home-assistant:dev Dec 13, 2023
23 checks passed
@mib1185 mib1185 deleted the fritzbox/fix-setup-when-delayed-platform-setup branch December 13, 2023 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVM FRITZ!SmartHome sensor entities of Fritz DECT 200 are missing after update to 2023.12
4 participants