add new s2s filter #46
Merged
+275
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smathangi
reviewed
Feb 28, 2020
|
|
||
| private final AuthTokenValidator authTokenValidator; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
you might need @component annotation for auto-wire or leave filter bean definition to calling services including @value.
There was a problem hiding this comment.
Good point, I have left he ServiceFilter as is and instead created the bean using AutoConfiguration that enables with conditional property.
nikola-naydenov-hmcts
approved these changes
Feb 28, 2020
timja
reviewed
Feb 28, 2020
timja
reviewed
Mar 3, 2020
src/main/java/uk/gov/hmcts/reform/authorisation/ServiceAuthAutoConfiguration.java
Show resolved
Hide resolved
README.md
Outdated
| @@ -50,6 +50,13 @@ A spring bean: | |||
|
|
|||
| } | |||
| ``` | |||
| ##Configuration for Service Authentication filter | |||
There was a problem hiding this comment.
Intellij didn't complain 👍
timja
reviewed
Mar 3, 2020
timja
reviewed
Mar 4, 2020
timja
reviewed
Mar 4, 2020
| ServiceAuthFilter bean is OncePerRequestFilter filter that you can add to your filter chain to authorise service | ||
| request. The filter will expect 'ServiceAuthorization' Bearer token as part of the request header that it will consume | ||
| to approve the request. Any requests from services that are not in your authorised services list will deny access | ||
| to your service and return an HTTP response status code 403 (forbidden) and for any other reasons if the token is |
There was a problem hiding this comment.
Suggested change
| to your service and return an HTTP response status code 403 (forbidden) and for any other reasons if the token is | |
| to your service, returning an HTTP response status code 403 (forbidden) and for any other reasons if the token is |
timja
reviewed
Mar 4, 2020
src/main/java/uk/gov/hmcts/reform/authorisation/filters/ServiceAuthFilter.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Mar 4, 2020
src/main/java/uk/gov/hmcts/reform/authorisation/filters/ServiceAuthFilter.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Mar 4, 2020
src/main/java/uk/gov/hmcts/reform/authorisation/validators/ServiceAuthTokenValidator.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
…eAuthFilter.java Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
…viceAuthTokenValidator.java Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
smathangi
approved these changes
Mar 4, 2020
…eAuthFilter.java Co-Authored-By: Tim Jacomb <tim.jacomb@hmcts.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
Change description
Create a new s2s filter.
Does this PR introduce a breaking change? (check one with "x")