Change default refreshTimeDelta to 5minutes instead of 0 seconds. #159
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch will remain open until the NFD team can upgrade to spring-boot 3 which will then enable us to test this change on our service. NFD spring-boot 3 upgrade: hmcts/nfdiv-case-api#2674 |
|
As NFD are using the 2nd default constructor to mimic the behaviour of setting the delta to 5minutes, we feel it's safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-3348
Change description
NFD service (and possibly others) are seeing that the refresh time is set to zero on our service and this is due to calling the default constructor which sets it to zero. Moving it to 5minutes as a default, as zero seems redundant.
Does this PR introduce a breaking change? (check one with "x")