Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-46 idam searchUsers api #97

Merged
merged 3 commits into from
Jul 22, 2020
Merged

ACA-46 idam searchUsers api #97

merged 3 commits into from
Jul 22, 2020

Conversation

smathangi
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/ACA-46

Change description

Exposed search-api

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

Verified

This commit was signed with the committer’s verified signature.
sfackler Steven Fackler
@smathangi smathangi requested review from doncem and timja July 20, 2020 15:29
@smathangi smathangi changed the title ACA-46 idam search-api ACA-46 idam searchUsers api Jul 20, 2020
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you plan to write a pact test for this?
https://github.com/hmcts/idam-java-client/tree/master/src/contractTest

(you might want to fix the directory structure if you are changing it, it's a single directory with .'s atm)

@smathangi
Copy link
Contributor Author

do you plan to write a pact test for this?
https://github.com/hmcts/idam-java-client/tree/master/src/contractTest

(you might want to fix the directory structure if you are changing it, it's a single directory with .'s atm)

sure, will write one. What's the directory structure I've to fix ?

@timja
Copy link
Contributor

timja commented Jul 22, 2020

a mistake was made in the PR that created the contract test, it's one folder with .'s in it

image

Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the pact test only runs on master, can you please verify it after merge?

@smathangi
Copy link
Contributor Author

Looks like the pact test only runs on master, can you please verify it after merge?

sure, looks like master is broken atm (pactPublish failure)

@smathangi smathangi merged commit 144877a into master Jul 22, 2020
@smathangi smathangi deleted the ACA-46 branch July 22, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants