UserInfo deserialization / serialization fix

[smathangi]

Change description

1. NoArgsConstructor for deserialization
2. added implements Serializable explicitly as some serializers are failing (Hazelcast)

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

[timja]

why do you need this?

[smathangi]

For deserialization. Otherwise i see error like below
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of uk.gov.hmcts.reform.idam.client.models.UserInfo (no Creators, like default construct, exist): cannot deserialize from Object value ...

[timja]

most likely your app is missing constructor parameters being added in the compile options

-parameters it should be on by default in spring boot 2 i think though

[smathangi]

even ObjectMapper.readValue(json, UserInfo.class) giving same error.

[timja]

plenty of teams are using this, try add https://github.com/spring-projects/spring-boot/tree/master/spring-boot-project/spring-boot-starters/spring-boot-starter-json as a dependency

[smathangi]

either it needs @JsonCreator or default constructor at least private.

[timja]

i'd be happier with jsoncreator

[smathangi]

tried with spring-boot-starter-json but same error.

[timja]

these json properties really shouldn't be needed and are a symptom of your application being misconfigured and not using the jackson-module-java8 correctly,

but not going to block you if you want to continue going down this route and it's just this one class you need the change in, not ok with modifying all the models for it.

[smathangi]

jackson-module-java8

Sorry, I still didn't get how to resolve deserialization error .
Parameter-names module docs says if there are multiple visible constructors and there is no default constructor, @JsonCreator is required to select constructor for deserialization
https://github.com/FasterXML/jackson-modules-java8/tree/master/parameter-names

[timja]

jackson-module-java8

Sorry, I still didn't get how to resolve deserialization error .
Parameter-names module docs says if there are multiple visible constructors and there is no default constructor, @JsonCreator is required to select constructor for deserialization
https://github.com/FasterXML/jackson-modules-java8/tree/master/parameter-names

yes but you don't need the json properties that you added.

[smathangi]

jackson-module-java8

Sorry, I still didn't get how to resolve deserialization error .
Parameter-names module docs says if there are multiple visible constructors and there is no default constructor, @JsonCreator is required to select constructor for deserialization
https://github.com/FasterXML/jackson-modules-java8/tree/master/parameter-names

yes but you don't need the json properties that you added.

It's my bad; I was testing this in IntelliJ and -parameters is not enabled automatically from gradle build config. Removed @JsonCreator completely as it's not required from jackson-databind > 2.7 . Cheers Tim.