Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(python) support type hints and better type support #2972

Merged
merged 9 commits into from
Mar 5, 2021
Merged

enh(python) support type hints and better type support #2972

merged 9 commits into from
Mar 5, 2021
+183 −53

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Jan 22, 2021 •
edited
Loading

Resolves #2633.

  • Also lints the Python grammar

Changes

  • Supports type hints in comments
  • Highlight types separately from built-ins

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

Sorry, something went wrong.

@joshgoebel joshgoebel marked this pull request as draft February 18, 2021 11:51
@joshgoebel joshgoebel removed the 0-WIP label Feb 18, 2021
@joshgoebel
begin
6051062
@joshgoebel
chore(lint) python
987f788
@joshgoebel
rejigger comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
33080fa
@joshgoebel
update tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f0e24f1
@joshgoebel joshgoebel marked this pull request as ready for review March 3, 2021 21:30
@joshgoebel joshgoebel requested review from allejo and egor-rogov March 3, 2021 21:30
allejo
allejo reviewed Mar 4, 2021
View reviewed changes
@joshgoebel
fix tests
cbfb6d7
@joshgoebel
extend the python type list

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0f070d0
allejo
allejo approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typos but lgtm

joshgoebel and others added 2 commits March 5, 2021 18:11
@joshgoebel @allejo
Update src/languages/python.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
12c635d 
Co-authored-by: Vladimir Jimenez <allejo@me.com>
@joshgoebel
Merge branch 'master' into python_type_hints
60398a0
@joshgoebel joshgoebel merged commit a5c0f1b into highlightjs:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo

@egor-rogov egor-rogov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Python) Better support for Python Type Hints
2 participants
@joshgoebel @allejo