-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(shell) Fix formatting when '/' is in a shell path #2218
Conversation
Please include some tests and update the changelog. :-) How does this differential between something like:
Where the / is part of the command, not the prompt? I think the ^ solves that but please add a |
I'd love to get this in the next release if you could make the requested changes/additions. |
I added a test, but I'm having trouble getting mocha to run with some of the relative require statements. Is there some magic NODE_PATH that needs to be set? Here is an example of what I am seeing:
|
I'm not sure what you're doing... all you need to do is drop two files into:
Look at the other languages for examples. You shouldn't need to add any actual JS code. Or if you mean you can't run the tests at all, then I'm not sure. OH you do need to build the "binary first":
|
1f5882e
to
1d798cc
Compare
Thanks! That was the issue. I had built for browser but not for node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need a changelog entry and this should be shippable!
Right now if you have a prompt like `bash /home/user#` the syntax highlighter doesn't correctly detect the prompt. This commit fixes that by adding / to the character set for prompt detection Co-Authored-By: Shishir Amin <samin@pivotal.io>
Updated the changelog |
It looks like the CI system errored and no tests actually failed |
Yikes. |
@z4ce Thanks so much for contributing! |
Right now if you have a prompt like
bash /home/user#
the syntax highlighter doesn't correctly detect the prompt.
This commit fixes that by adding / to the character set for
prompt detection