Groupings and Improved Ingredient Parsing for JamieOliver #1434
+501
−1,257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! Thanks and don't worry about the failing coverage CI. I'm currently updating our GitHub Actions and things are in a bit of a limbo state. This will be merged later today. |
|
I thought I was going crazy! I figured it could be related to that but was trying to hunt it down myself as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls new test data for the original test case which shows that the changes implemented in #1432 work on current site, also updates several test results. Also adds support for groupings which required implementation of custom ingredient gathering to exclude headers which are included in the schema output.