fix(disableNunjucks): query both async and sync versions of renderer #4498
+34
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
A workaround to fix #3860,
disableNunjucks
may not be reliable in synchronous mode. The issue could be due toPromise.method()
not includingdisableNunjucks
property.Before: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030164260
After: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030174895
How to test
Screenshots
Pull request tasks