Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(disableNunjucks): query both async and sync versions of renderer #4498

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 26, 2020

What does it do?

A workaround to fix #3860, disableNunjucks may not be reliable in synchronous mode. The issue could be due to Promise.method() not including disableNunjucks property.

Before: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030164260
After: https://github.com/hexojs/hexo-renderer-coffeescript/pull/72/checks?check_run_id=1030174895

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Sorry, something went wrong.

@coveralls
Copy link

coveralls commented Aug 26, 2020

Coverage Status

Coverage increased (+0.003%) to 98.299% when pulling bdd4156 on curbengh:disable-nunjucks-sync into 08c8b23 on hexojs:master.

@curbengh curbengh marked this pull request as ready for review August 27, 2020 03:07
@curbengh curbengh changed the title fix(disableNunjucks): attempt both async and sync versions of renderer fix(disableNunjucks): query both async and sync versions of renderer Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent check for Nunjucks disabling flag
3 participants