Correct using createSha1Hash() with pipe() #4323
Merged
+16
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix errors of the issue #3818. (#3818 (comment))
Supersede the draft PR #4292.
With Node.js v10.x (not v12.x),
npm test
fails some times.One of them is
process() - skip (mtime changed but hash matched):
as follows:Another one of them is
update theme source files:
as follows:This patch fixes these errors.
I found that a combination
Stream.readable.pipe()
andCrypt.createHash()
causes this error.As shown by the @segayuu 's comment (#4292 (comment)),
Hash#digest()
can not be used in thefinish
event ofHash#pipe()
.This patch uses the
data
event ofHash#pipe()
to get hash buffer,and uses
Buffer#toString('hex')
to get digest value from the buffer.How to test
Pull request tasks