Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(flamegraph): fix 0x #4116

Merged
merged 1 commit into from
Feb 16, 2020
Merged

ci(flamegraph): fix 0x #4116

merged 1 commit into from
Feb 16, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Feb 8, 2020

What does it do?

Attempt to fix surge.sh deployment.

How to test

To see if Travis CI build of this PR has succeed.

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Sorry, something went wrong.

@SukkaW SukkaW marked this pull request as ready for review February 9, 2020 08:27
@SukkaW SukkaW requested a review from a team February 9, 2020 08:27
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about this part :)

BTW, a flamegraph.html seems doesn't publish from the beginning (#4000)
Sorry, I didn't notice and approved it...

@SukkaW
Copy link
Member Author

SukkaW commented Feb 12, 2020

@yoshinorin This PR is attempt to fix the failed deployment after #4000. The problem is 0x isn't installed under hexo dummy site thus no flamegraph is generated. This PR fixes it.

@SukkaW SukkaW requested a review from yoshinorin February 14, 2020 05:59
@SukkaW SukkaW merged commit 7f0537f into hexojs:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants