-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(load-database): fix EPERM error in windows #4069
Conversation
e7dccf4
to
2e97a09
Compare
Strangely. Travis build is fine in my newest PR #4070. It looks like the |
e9ec221
to
07194c6
Compare
the behavior is erratic. |
a843fa1
to
1cd60a1
Compare
Still have soft error in Node 8 Windows:
#4037 may help (or not, see hexojs/hexo-fs#49 hexojs/hexo-fs#50). |
@curbengh What about patch |
Another workaround I can think of is adding a delay (as used in this PR), Line 528 in 5c098cc
Node's FS api can be tricky in Windows microsoft/azure-pipelines-tasks#5472 |
If the workaround doesn't work, then this PR is ready (I can't think of any other workaround). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does it do?
Continuation of #3975
Add workarounds for more reliable unit testing on Windows in CI env.
How to test
Screenshots
Pull request tasks