fix(load-balancer): automatic import of target adds conflicting fields #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields `ip` and `use_private_ip` are marked as conflicting because `use_private_ip` only takes effect with label selector and server id targets. So far we have always set `use_private_ip` to whatever the API returned. But this causes issues with the command `terraform plan -generate-config-out=` as it writes all attributes we set in the state to a TF file. For an LB Target IP this now causes a conflict because both fields are set. This is fixed by only setting the field when the target type is not IP. Closes #961.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
===========================================
+ Coverage 34.06% 69.64% +35.57%
===========================================
Files 63 63
Lines 7928 7929 +1
===========================================
+ Hits 2701 5522 +2821
+ Misses 5188 1709 -3479
- Partials 39 698 +659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Jul 24, 2024
apricote
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.48.0](v1.47.0...v1.48.0) (2024-07-25) ### Features * add support for opentofu v1.7 ([#950](#950)) ([ae115a8](ae115a8)) * add support for terraform v1.9 ([#949](#949)) ([642ac15](642ac15)) * drop support for terraform v1.7.x ([#947](#947)) ([f6372aa](f6372aa)) * **server-type:** mark included_traffic attribute as deprecated ([#963](#963)) ([e8101cc](e8101cc)) ### Bug Fixes * do not continue if an api error occurred ([#958](#958)) ([85a4dd0](85a4dd0)) * **load-balancer:** automatic import of target adds conflicting fields ([#962](#962)) ([6c0b1c4](6c0b1c4)), closes [#961](#961) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields
ipanduse_private_ipare marked as conflicting becauseuse_private_iponly takes effect with label selector and server id targets.So far we have always set
use_private_ipto whatever the API returned. But this causes issues with the commandterraform plan -generate-config-out=as it writes all attributes we set in the state to a TF file. For an LB Target IP this now causes a conflict because both fields are set.This is fixed by only setting the field when the target type is not IP.
Closes #961