fix(server): cannot update placement group #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
===========================================
+ Coverage 33.70% 69.80% +36.09%
===========================================
Files 56 63 +7
Lines 7734 7938 +204
===========================================
+ Hits 2607 5541 +2934
+ Misses 5110 1704 -3406
- Partials 17 693 +676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apricote
force-pushed
the
fix-server-placement-group
branch
from
fa04176 to
1fad321
Compare
apricote
approved these changes
Apr 5, 2024
apricote
pushed a commit
that referenced
this pull request
Apr 8, 2024
🤖 I have created a release *beep* *boop* --- ## [1.46.1](v1.46.0...v1.46.1) (2024-04-05) ### Bug Fixes * **server:** cannot update placement group ([#902](#902)) ([fa5f98c](fa5f98c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
placement_groupfield name must beplacement_group_id, the placement group could not be updated while using the wrong field name.When no placement group is set, we find an id of
0, which seem to be expected by Terraform.