-
Notifications
You must be signed in to change notification settings - Fork 78
Comparing changes
Open a pull request
base repository: hetznercloud/terraform-provider-hcloud
base: v1.42.0
head repository: hetznercloud/terraform-provider-hcloud
compare: v1.42.1
- 8 commits
- 8 files changed
- 4 contributors
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 62e9781 - Browse repository at this point
Copy the full SHA 62e9781View commit details
Commits on Aug 8, 2023
-
deps: update module golang.org/x/crypto to v0.12.0 (#728)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 16ac875 - Browse repository at this point
Copy the full SHA 16ac875View commit details
Commits on Aug 14, 2023
-
deps: update module github.com/hetznercloud/hcloud-go to v1.49.0 (#733)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 081ce78 - Browse repository at this point
Copy the full SHA 081ce78View commit details -
fix: use exponential backoff when retrying actions (#735)
Exponential backoff is better suited to reduce the average amount of calls needed. We are already using it to wait for running Actions.
Configuration menu - View commit details
-
Copy full SHA for d51ee4a - Browse repository at this point
Copy the full SHA d51ee4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d57b386 - Browse repository at this point
Copy the full SHA d57b386View commit details -
fix(server): Return
nil
instead of"<nil>"
with IPv4/IPv6 disabled (#723) Why: `"<nil>"` isn't very easy to work with in terraform. e.g. there are functions to work with null or the empty string (""), like `compact()` or `coalesce()`, but nothing exists to handle `"<nil>"` natively, making it an odd one and requiring specific custom filtering constructs to work with it. `"<nil>"` is a pretty common thing to return in golang, with tens of usages even in the main repo[1] but HCL is not golang hcloud-go has a very nice IsUnspecified()[1] function to detect if the API returned an unspecified IP address and a quick check says that the hcloud cli command uses it to provide custom text output. What: Switch from using unconditionally the output of net.IP.String() function, which returns `"<nil>"`[2] if the IP has length 0, to a conditional usage of the function, setting the address to nil otherwise. Setting the entire struct to nil apparently locally appeases unit tests just fine and even works in some, very simple, scenarios just fine, returning the empty string ("") instead of `"<nil>"` This is an API breaking change. It might not be desirable to merge and/or require some careful handling depending on how widespread the usage of handling `"<nil>"` is. A quick search on my side, did not find any usages[3], but I might have very well failed. [1] https://github.com/search?q=repo%3Agolang%2Fgo%20%22%3Cnil%3E%22&type=code [2] https://pkg.go.dev/net#IP.String [3] https://github.com/search?q=%22%3Cnil%3E%22+language%3AHCL&type=code Signed-off-by: Alexandros Kosiaris <akosiaris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6cd2a37 - Browse repository at this point
Copy the full SHA 6cd2a37View commit details -
deps: update module golang.org/x/net to v0.14.0 (#726)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 530891c - Browse repository at this point
Copy the full SHA 530891cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e14ea6 - Browse repository at this point
Copy the full SHA 8e14ea6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.42.0...v1.42.1