Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile with Angular 8 #7

Open
wmaurer opened this issue Jun 14, 2019 · 8 comments
Open

Fails to compile with Angular 8 #7

wmaurer opened this issue Jun 14, 2019 · 8 comments

Comments

@wmaurer
Copy link
Contributor

wmaurer commented Jun 14, 2019

The InternalNgModuleRef interface is no longer exported from @angular/core.
The best solution I can think of is to redefine InternalNgModuleRef in dynamic-component.service.ts

wmaurer added a commit to wmaurer/herodevs-packages that referenced this issue Jun 14, 2019
`InternalNgModuleRef` is no longer exported from `@angular/core`. This solution simply redefines it.
Solves herodevs#7.
@sujitgawas19
Copy link

Angular 8 prod build fails with following error : ERROR in node_modules/@herodevs/dynamic-af/lib/dynamic-af.service.d.ts(2,37): error TS2307: Cannot find module '@angular/core/src/linker/ng_module_factory'.

@giampierobono
Copy link

Any news about this?

@wmaurer
Copy link
Contributor Author

wmaurer commented Jul 11, 2019

It seems to have been merged, but not yet published to npm.
@aaronfrost could you please publish?

@aaronfrost
Copy link
Contributor

aaronfrost commented Jul 11, 2019

I thought I published 2.0.1 to NPM. Are you sure? @wmaurer

@wmaurer
Copy link
Contributor Author

wmaurer commented Jul 11, 2019

@aaronfrost sorry, my fault. Somehow I've been using lazy-af and not hero-loader. Rather confusing. Maybe the lazy-af package should have a deprecation notice ... ;-)

@aaronfrost
Copy link
Contributor

@wmaurer I think that most people are still using lazy-af. I need to push a deprecated message to lazy-af so that people can see it and switch to hero-loader.

@wmaurer
Copy link
Contributor Author

wmaurer commented Jul 12, 2019

Please do, I think that would make a lot of sense.

@jindovu
Copy link

jindovu commented Oct 11, 2019

any update on this one, I still got this issue, please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants