Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: heremaps/here-sbt-bom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.21
Choose a base ref
...
head repository: heremaps/here-sbt-bom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.25
Choose a head ref
  • 5 commits
  • 28 files changed
  • 2 contributors

Commits on Dec 10, 2024

  1. [skip release] Fix syntax for bash shell (#35)

    Signed-off-by: Anton Wilhelm <anton.wilhelm@here.com>
    devtonhere authored Dec 10, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    phillebaba Philip Laine
    Copy the full SHA
    7763f14 View commit details
  2. [skip release] Allow to fail check-skip-commit job (#36)

    Signed-off-by: Anton Wilhelm <anton.wilhelm@here.com>
    devtonhere authored Dec 10, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ad91aca View commit details
  3. [skip release] Move skip release logic to shell scripts (#37)

    Signed-off-by: Anton Wilhelm <anton.wilhelm@here.com>
    devtonhere authored Dec 10, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    d55d121 View commit details

Commits on Dec 11, 2024

  1. [skip release] Reduce logging of scripted tests

    Signed-off-by: Oleksandr Vyshniak <ext-oleksandr.vyshniak@here.com>
    molekyla committed Dec 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4a73b5c View commit details
  2. Update year copyright header (#38)

    Signed-off-by: Anton Wilhelm <anton.wilhelm@here.com>
    devtonhere authored Dec 11, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    cbe621d View commit details
Showing with 31 additions and 33 deletions.
  1. +5 −0 .github/scripts/deploy.sh
  2. +5 −0 .github/scripts/push-tag.sh
  3. +0 −8 .github/workflows/release.yml
  4. +1 −1 LICENSE
  5. +0 −1 build.sbt
  6. +1 −1 plugin/src/main/scala/com/here/bom/Bom.scala
  7. +1 −1 plugin/src/main/scala/com/here/bom/internal/BomReader.scala
  8. +1 −1 plugin/src/main/scala/com/here/bom/internal/DependencyResolutionProxy.scala
  9. +1 −1 plugin/src/main/scala/com/here/bom/internal/IvyPomLocator.scala
  10. +1 −1 plugin/src/main/scala/com/here/bom/internal/NormalizedArtifact.scala
  11. +1 −1 plugin/src/sbt-test/psv/custom_ivy_home_config/project/Dependencies.scala
  12. +1 −1 plugin/src/sbt-test/psv/custom_ivy_home_config/src/main/scala/CustomIvyTestApp.scala
  13. +0 −1 plugin/src/sbt-test/psv/custom_ivy_home_config/test
  14. +1 −1 plugin/src/sbt-test/psv/custom_ivy_home_config_related_path/project/Dependencies.scala
  15. +1 −1 plugin/src/sbt-test/psv/custom_ivy_home_config_related_path/src/main/scala/CustomIvyTestApp.scala
  16. +0 −1 plugin/src/sbt-test/psv/custom_ivy_home_config_related_path/test
  17. +1 −1 plugin/src/sbt-test/psv/simple_1.3.0/project/Dependencies.scala
  18. +1 −1 plugin/src/sbt-test/psv/simple_1.3.0/src/main/scala/Demo.scala
  19. +1 −1 plugin/src/sbt-test/psv/simple_1.6.1/project/Dependencies.scala
  20. +1 −1 plugin/src/sbt-test/psv/simple_1.6.1/src/main/scala/Demo.scala
  21. +1 −1 plugin/src/sbt-test/psv/test_downloaded_deps/src/main/scala/TestApp.scala
  22. +0 −1 plugin/src/sbt-test/psv/test_downloaded_deps/test
  23. +1 −1 plugin/src/sbt-test/psv/with_project_version/src/main/scala/Demo.scala
  24. +1 −1 plugin/src/sbt-test/sv/password-protected-repo_1.6.1/project/Dependencies.scala
  25. +1 −1 plugin/src/sbt-test/sv/password-protected-repo_1.6.1/src/main/scala/Demo.scala
  26. +1 −1 plugin/src/test/scala/com/here/bom/BomSpec.scala
  27. +1 −1 plugin/src/test/scala/com/here/bom/internal/BomReaderSpec.scala
  28. +1 −1 plugin/src/test/scala/com/here/bom/internal/IvyPomLocatorSpec.scala
5 changes: 5 additions & 0 deletions .github/scripts/deploy.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/bin/bash
set -ev

if [[ $(git log -1 --pretty=format:"%s") =~ "[skip release]" ]]; then
echo 'Stopping the script because [skip release] was found in commit message'
exit 0
fi

export GPG_TTY=$(tty)
export SONATYPE_USERNAME=$OSSRH_USERNAME
export SONATYPE_PASSWORD=$OSSRH_PASSWORD
5 changes: 5 additions & 0 deletions .github/scripts/push-tag.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
#!/bin/bash
set -ev

if [[ $(git log -1 --pretty=format:"%s") =~ "[skip release]" ]]; then
echo 'Stopping the script because [skip release] was found in commit message'
exit 0
fi

# Prepare release
git config user.name "GitHub Action"
git config user.email "ARTIFACT_SERVICE_SUPPORT@here.com"
8 changes: 0 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -20,29 +20,21 @@ jobs:
ref: master
fetch-depth: 0

- name: Check Skip Commit
id: checkskip
run: if [[ $(git log -1 --pretty=format:"%s") =~ "\[skip release\]" ]]; then false; else true; fi

- name: Set up JDK 8
if: steps.checkskip.conclusion == 'success'
uses: actions/setup-java@v3
with:
java-version: '8'
distribution: 'adopt'
- name: Cache SBT
if: steps.checkskip.conclusion == 'success'
uses: actions/cache@v3
with:
path: |
~/.ivy2/cache
~/.sbt
key: ${{ runner.os }}-sbt-${{ hashFiles('**/build.sbt', 'project/**') }}
- name: Push git tag
if: steps.checkskip.conclusion == 'success'
run: ./.github/scripts/push-tag.sh
- name: Deploy
if: steps.checkskip.conclusion == 'success'
env:
OSSRH_USERNAME: ${{ secrets.OSSRH_USERNAME }}
OSSRH_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (C) 2019-2024 HERE Europe B.V.
Copyright (C) 2019-2025 HERE Europe B.V.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
1 change: 0 additions & 1 deletion build.sbt
Original file line number Diff line number Diff line change
@@ -86,7 +86,6 @@ lazy val `sbt-bom` = project
scriptedLaunchOpts.value ++
Seq("-Dplugin.version=" + version.value)
},
scriptedBufferLog := false,
libraryDependencies ++= Seq(
"org.scalatest" %% "scalatest" % "3.2.15" % Test,
"org.scalamock" %% "scalamock" % "5.2.0" % Test
2 changes: 1 addition & 1 deletion plugin/src/main/scala/com/here/bom/Bom.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
1 change: 0 additions & 1 deletion plugin/src/sbt-test/psv/custom_ivy_home_config/test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
> set scriptedBufferLog := false
> eval System.setProperty("ivy.home", "/tmp/custom-ivy-home")
> eval System.setProperty("sbt.ivy.home", "/tmp/custom-sbt-ivy-home")
# check that build failed for the different custom home locations
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
> set scriptedBufferLog := false
> eval System.setProperty("ivy.home", "./custom-ivy-home")
> eval System.setProperty("sbt.ivy.home", "./custom-ivy-home")
# check that build succeeded
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
1 change: 0 additions & 1 deletion plugin/src/sbt-test/psv/test_downloaded_deps/test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
> set scriptedBufferLog := false
> eval System.setProperty("sbt.ivy.home", System.getProperty("java.io.tmpdir")+"/test-sbt-bom-cache")
> eval System.setProperty("ivy.home", System.getProperty("java.io.tmpdir")+"/test-sbt-bom-cache")
> set ivyPaths := IvyPaths.apply(file(System.getProperty("java.io.tmpdir")+"/test-sbt-bom-cache"), file(System.getProperty("java.io.tmpdir")+"/test-sbt-bom-cache"))
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
2 changes: 1 addition & 1 deletion plugin/src/test/scala/com/here/bom/BomSpec.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2019-2024 HERE Europe B.V.
* Copyright (C) 2019-2025 HERE Europe B.V.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.