Use sudo (if available) when installing sccache #273
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running this action inside a container as a non-root user, installing sccache will typically fail due to the non-root user not having write permissions to /usr/local/bin. This patch fixes this by using sudo for downloading/installing sccache along with some modifications to executeShellSudo so that it will execute the entire command as expected.
hendrikmuhs
added a commit
that referenced
this pull request
Jan 11, 2025
This reverts commit f5df292.
Merged
hendrikmuhs
added a commit
that referenced
this pull request
Jan 11, 2025
|
I had to revert #273 as it caused failures, feel free to re-open the PR. |
Sorry about that. I don't think Github supports reopening merged PRs. I'll open another PR with the issues fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this action inside a container as a non-root user, installing sccache will typically fail due to the non-root user not having write permissions to /usr/local/bin. This patch fixes this by using sudo for downloading/installing sccache along with some modifications to executeShellSudo so that it will execute the entire command as expected.