Support diff --detailed-exitcode

[jkroepke]

The running helmfile diff --detailed-exitcode expect exit code 2 on a success run.

From github actions point of view, it's not possible to allow specific exit code. If helm diff detect changes, it would exit with exit code 2 and helmfile, too. This would result into an action failure.

Proposed solution:

Catch the exit code 2 from helmfile and return exit code 0 to GitHub actions. The exit code should be stored into an output variable.

Use-Case: Run the deploy step only if there is a diff.

[yxxhero]

@jkroepke PR is welcome.
@bonddim did you have free time for the issue? thanks so much.

[bonddim]

You're very fast with this :)
I thought to add additional input to ignore exit code and not ignore it by default as was added by current PR...

[yxxhero]

@bonddim PR is welcome.

[yxxhero]

@bonddim would you have time to take a look at this isuee? thanks so much.

[bonddim]

@yxxhero,
Yes, I'll do, but I have no time for this now.

[yxxhero]

@jkroepke @bonddim ok. thanks for your feedback. it will release a new one when this issue is fixed.

[jkroepke]

From my point of view, the issue this fixed and

I thought to add additional input to ignore exit code and not ignore it by default as was added by current PR...

can be handled as separate issue.

The PR only ignore exit code 2, exit code 1 and 3 or higher are still raised as error. Look at hashicorp/setup-terraform#125, they implement the same behavior. I people assume that exit code 2 would not overlap which real errors, otherwise using exit code 2 for detect changes can not be considered as safe.

[bonddim]

@yxxhero, @jkroepke is right.
You may close this issue as resolved

[yxxhero]

@bonddim got it. closed.