Fix issues when verify generation readiness was merged #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI, tests, and building failed after helm#10920 was merged. This change fixes the issues that were introduced. Signed-off-by: Matt Farina <matt.farina@suse.com>
pull-request-size
bot
added
the
size/S
scottrigby
reviewed
Jan 9, 2024
Comment on lines
-93
to
-99
| var ( | ||
| // This defaults to true, otherwise we get to a point where | ||
| // things will always return false unless one of the objects | ||
| // that manages pods has been hit | ||
| ok = true | ||
| err error | ||
| ) |
There was a problem hiding this comment.
Looking over 10920 I get why we need the rest of the fixes, but can you help clarify this part? Tempted to rubber stamp but just checking on this.
There was a problem hiding this comment.
Those variables were used as part of the code that was removed. They are now unused variables so the Go compiler gives an area. The code that uses them is gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI, tests, and building failed after #10920 was merged. This change fixes the issues that were introduced.
What this PR does / why we need it: CI, building, testing, and linting are failing on master due to issues introduced in a PR where CI passed. This change fixes the codebase.
Special notes for your reviewer: The issue here is blocking the release of the RC for Helm 3.14.
If applicable: