lint: Add --kube-version flag to set capabilities and deprecation rules

[antoinedeschenes]

Signed-off-by: Antoine Deschênes antoine@antoinedeschenes.com

What this PR does / why we need it:
closes #10664

Adds a --kube-version flag to the helm lint command, allowing to specify the Kubernetes version to use for the deprecation check warnings.

There's a similar flag in the helm template command.

Specific example of where this is useful:

• helm 3.8.0 releases are currently targetting Kubernetes 1.23.
• We're currently running Kubernetes 1.22 clusters.
• helm lint --strict is currently erroring out on HorizontalPodAutoscaler autoscaling/v2beta2 having to be replaced by autoscaling/v2.
• autoscaling/v2 doesn't exist yet on Kubernetes 1.22.

If applicable:

• this PR contains documentation
• this PR contains unit tests
• this PR has been tested for backwards compatibility

[yxxhero]

ping @antoinedeschenes

[antoinedeschenes]

@yxxhero Just reversed All and Templates signatures to the original, added new functions in parallel.

[antoinedeschenes]

pign @yxxhero

[joejulian]

Nice. This is what I originally had hoped to do when I added the upstream deprecation library. Thanks!

[antoinedeschenes]

@joejulian Awesome, do you need a rebase?

[joejulian]

Not according to GitHub

[pete-woods]

@yxxhero I don't like to nag, but this PR adds something super useful for us, and has been waiting for some time

[joejulian]

@pete-woods @yxxhero and I are just triage maintainers. You need a core maintainer to review.

[yxxhero]

@joejulian me too.

[pete-woods]

Ah. Didn't appreciate that - apologies

[mattfarina]

Thanks for this PR. I've long wanted this feature and am excited for it to land.

I found one minor issue that shows up for SDK consumers. Should be a quick fix if you could please make the change. Otherwise it looks good to me.

[mattfarina]

@antoinedeschenes can you make the one small change or should someone else make it?

[antoinedeschenes]

Anything missing?

[zifter]

Any updates?

[joejulian]

Tested this and it works for me. I wish we could make it an error if it's past the unavailable deadline, but that would be a breaking change, I guess, and outside the scope of this PR.

[antoinedeschenes]

Any timeframe in mind?

[mattfarina]

Note, I fixed a merge conflict caused by #12688 where strict became _. An unused argument. This was to pass linting.

[mattfarina]

Since my commit should not have made major changes to cause the failed test run, I checked out the commit before it and ran the test suite there. I get the same error of...

--- FAIL: TestLintCmdWithKubeVersionFlag (0.01s)
    --- FAIL: TestLintCmdWithKubeVersionFlag/lint_chart_with_deprecated_api_version_without_kube_version (0.00s)
        helm_test.go:61: running cmd (attempt 1): lint testdata/testcharts/chart-with-deprecated-api
        helm_test.go:70: does not match golden file testdata/output/lint-chart-with-deprecated-api.txt

            WANT:
            '==> Linting testdata/testcharts/chart-with-deprecated-api
            [INFO] Chart.yaml: icon is recommended
            [WARNING] templates/horizontalpodautoscaler.yaml: autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.25+; use autoscaling/v2 HorizontalPodAutoscaler

            1 chart(s) linted, 0 chart(s) failed
            '

            GOT:
            '==> Linting testdata/testcharts/chart-with-deprecated-api
            [INFO] Chart.yaml: icon is recommended

            1 chart(s) linted, 0 chart(s) failed
            '

This is for commit 46e3886.

This is because the internal k8s version is set to 1.20 which is what's used for the testing. So the lint command without setting the Kubernetes version uses this which would not produce the error.

I'm not sure how this test ever passed.

The easy fix is to update k8sVersionMinor.

[joejulian]

Since my commit should not have made major changes to cause the failed test run, I checked out the commit before it and ran the test suite there. I get the same error of...

--- FAIL: TestLintCmdWithKubeVersionFlag (0.01s)
    --- FAIL: TestLintCmdWithKubeVersionFlag/lint_chart_with_deprecated_api_version_without_kube_version (0.00s)
        helm_test.go:61: running cmd (attempt 1): lint testdata/testcharts/chart-with-deprecated-api
        helm_test.go:70: does not match golden file testdata/output/lint-chart-with-deprecated-api.txt

            WANT:
            '==> Linting testdata/testcharts/chart-with-deprecated-api
            [INFO] Chart.yaml: icon is recommended
            [WARNING] templates/horizontalpodautoscaler.yaml: autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.25+; use autoscaling/v2 HorizontalPodAutoscaler

            1 chart(s) linted, 0 chart(s) failed
            '

            GOT:
            '==> Linting testdata/testcharts/chart-with-deprecated-api
            [INFO] Chart.yaml: icon is recommended

            1 chart(s) linted, 0 chart(s) failed
            '

This is for commit 46e3886.

This is because the internal k8s version is set to 1.20 which is what's used for the testing. So the lint command without setting the Kubernetes version uses this which would not produce the error.

I'm not sure how this test ever passed.

The easy fix is to update k8sVersionMinor.

This should have made it work: 869c1d2#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R107

But it broke a bunch of other golden images that have labels with the k8s version data.

Rather than have to update the golden files with every client-go release, I reverted the addition of ldflags on the test and switched the expected golden image to the old k8s one.

[joejulian]

sorry for my force-pushes. I neglected to sign my commit and am trying to help get this across the finish line for this release.