Throw user cancellation exception if the job was cancelled before it was initialized [5.3.z] #25452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-jamroz
added
Type: Defect
Source: Internal
TomaszGaweda
approved these changes
Sep 14, 2023
burakgok
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong exception was thrown if the job was cancelled very early by the user. Instead of specific
CancellationByUserExceptionthe genericCancellationExceptionwas thrown. This caused some flakiness in unit tests (see eg. https://jenkins.hazelcast.com/job/Hazelcast-pr-builder/20340/testReport/junit/com.hazelcast.jet.impl/JobSummaryTest/when_batchJob_cancelled/)Not adding unit test because there does not seem to be an easy way to trigger this situation.
Backport of: #25383
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset