Fix K8s service port [CN-894] #24834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeriyBg
added
Type: Defect
Source: Internal
SeriyBg
requested review from
a team,
hasancelik and
semihbkgr
and removed request for
a team
semihbkgr
reviewed
Jun 16, 2023
| JsonValue servicePort = port.asObject().get("port"); | ||
| if (servicePort != null && servicePort.isNumber()) { | ||
| return servicePort.asInt(); | ||
| } | ||
| } | ||
| } | ||
| if (ports.size() > 0) { | ||
| if (ports.size() == 1) { |
There was a problem hiding this comment.
Why changed in this way equals to 1
There was a problem hiding this comment.
Anyway, It is not a big deal. In the best practice, we assume to have a port named as hazelcast.
semihbkgr
approved these changes
Jun 16, 2023
This was referenced Jun 19, 2023
hasancelik
approved these changes
Jun 19, 2023
SeriyBg
added a commit
that referenced
this pull request
Jun 19, 2023
Backport of: #24834 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Label `Add to Release Notes` or `Not Release Notes content` set - [X] Request reviewers if possible - [X] Send backports/forwardports if fix needs to be applied to past/future releases - [X] New public APIs have `@Nonnull/@Nullable` annotations - [X] New public APIs have `@since` tags in Javadoc
SeriyBg
added a commit
that referenced
this pull request
Jul 3, 2023
Backport of: #24834 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Label `Add to Release Notes` or `Not Release Notes content` set - [X] Request reviewers if possible - [X] Send backports/forwardports if fix needs to be applied to past/future releases - [X] New public APIs have `@Nonnull/@Nullable` annotations - [X] New public APIs have `@since` tags in Javadoc
This was referenced Aug 16, 2023
SeriyBg
added a commit
that referenced
this pull request
Aug 16, 2023
Backport of: #24834 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Label `Add to Release Notes` or `Not Release Notes content` set - [X] Request reviewers if possible - [X] Send backports/forwardports if fix needs to be applied to past/future releases - [X] New public APIs have `@Nonnull/@Nullable` annotations - [X] New public APIs have `@since` tags in Javadoc
SeriyBg
added a commit
that referenced
this pull request
Aug 16, 2023
Backport of: #24834 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Label `Add to Release Notes` or `Not Release Notes content` set - [X] Request reviewers if possible - [X] Send backports/forwardports if fix needs to be applied to past/future releases - [X] New public APIs have `@Nonnull/@Nullable` annotations - [X] New public APIs have `@since` tags in Javadoc
devOpsHazelcast
pushed a commit
that referenced
this pull request
Feb 26, 2024
Backport of: #24834 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Label `Add to Release Notes` or `Not Release Notes content` set - [X] Request reviewers if possible - [X] Send backports/forwardports if fix needs to be applied to past/future releases - [X] New public APIs have `@Nonnull/@Nullable` annotations - [X] New public APIs have `@since` tags in Javadoc GitOrigin-RevId: 5bbb6b4476a0a8b5a737d7a3fc47dab803301a6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the port name from
hazelcast-service-portthat is longer than 15 characters tohazelcast.Fixes #24688
Fixes #24705
Breaking changes (list specific methods/types/messages):
Checklist:
Team:,Type:,Source:,Module:) and Milestone setAdd to Release NotesorNot Release Notes contentset@Nonnull/@Nullableannotations@sincetags in Javadoc