Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename data link to data connection [HZ-2231] #24224

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Rename data link to data connection [HZ-2231] #24224

merged 8 commits into from
Apr 6, 2023

Conversation

frant-hartm
Copy link
Contributor

@frant-hartm frant-hartm commented Apr 6, 2023 •
edited by k-jamroz

We previously renamed the external data store to a data link. After a few rounds of discussion, it was decided that data connection is a better term.

We never released this functionality as data link. In 5.2 the external data store was marked with @beta.

Client protocol PR: hazelcast/hazelcast-client-protocol#464
EE PR: https://github.com/hazelcast/hazelcast-enterprise/pull/5904

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible

@frant-hartm frant-hartm added this to the 5.3.0 milestone Apr 6, 2023
@frant-hartm frant-hartm requested a review from a team as a code owner April 6, 2023 09:40
k-jamroz
k-jamroz reviewed Apr 6, 2023
View reviewed changes
hazelcast-sql/src/main/codegen/includes/parserImpls.ftl Outdated
@@ -790,12 +790,12 @@ SqlShowStatement SqlShowStatement() :
|
<TYPES> { target = ShowStatementTarget.TYPES; }
|
<DATA> <LINKS> { target = ShowStatementTarget.DATALINKS; }
<DATA> <LINKS> { target = ShowStatementTarget.DATACONNECTIONS; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<LINKS> -> <CONNECTIONS>

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hazelcast-enterprise: Compilation failure: Compilation failure: 
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[54,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[61,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[38,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[292,40] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,12] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,45] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[297,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[408,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,16] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,49] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[410,70] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,17] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,28] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,18] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,56] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,29] error: invalid method reference
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hazelcast-enterprise: Compilation failure: Compilation failure: 
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[54,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[61,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[38,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[292,40] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,12] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,45] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[297,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[408,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,16] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,49] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[410,70] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,17] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,28] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,18] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,56] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,29] error: invalid method reference
--------------------------

mdumandag
mdumandag approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol-related changes are OK

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:license-maven-plugin:2.0.0:add-third-party (add-third-party) on project hazelcast-jet-elasticsearch-7: could not init goal AddThirdPartyMojo for reason : null: ConcurrentModificationException -> [Help 1]
--------------------------

TomaszGaweda
TomaszGaweda reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@TomaszGaweda TomaszGaweda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments.
7h8ps2

docs/design/jet/022-mongodb-connector.md Outdated
'dataLinkRef'='mongodb-ref'
)
DATA CONNECTION "mongodb-ref"
TYPE MONGODB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is redundant now, maybe worth removing where possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5b46977

docs/design/jet/022-mongodb-connector.md Outdated
@@ -138,7 +136,7 @@ CREATE MAPPING people (
)
TYPE MONGODB
OPTIONS (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there it should use DATA CONNECTION "mongodb-ref" syntax (I cannot make a suggestion as GitHub sees it as deleted line)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5b46977

docs/design/jet/022-mongodb-connector.md Outdated Show resolved Hide resolved
docs/design/sql/18-data-connections.md Outdated Show resolved Hide resolved
frant-hartm and others added 2 commits April 6, 2023 12:40
@frant-hartm @TomaszGaweda
Update docs/design/jet/022-mongodb-connector.md
9254940 
Co-authored-by: Tomasz Gawęda <tomasz.gaweda@outlook.com>
@frant-hartm @TomaszGaweda
Update docs/design/sql/18-data-connections.md
20d39b7 
Co-authored-by: Tomasz Gawęda <tomasz.gaweda@outlook.com>
@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hazelcast-enterprise: Compilation failure: Compilation failure: 
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[54,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[61,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[38,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[292,40] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,12] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,45] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[297,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[408,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,16] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,49] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[410,70] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,17] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,28] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,18] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,56] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,29] error: invalid method reference
--------------------------

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
-------TEST FAILURE-------
--------------------------
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   JetSerializableTest.serializable_classes_should_have_valid_serialVersionUID:40 Architecture Violation [Priority: MEDIUM] - Rule 'classes that are not enums and do not have modifier ABSTRACT and implement java.io.Serializable and do not implement com.hazelcast.nio.serialization.DataSerializable and are not anonymous classes should have a valid serialVersionUID' was violated (1 times):
serialVersionUID field is missing in class com.hazelcast.jet.impl.connector.WriteJdbcP$WriteJdbcSupplier
[INFO] 
[ERROR] Tests run: 54741, Failures: 1, Errors: 0, Skipped: 244
[INFO] 

[ERROR] There are test failures.

Fly-Style
Fly-Style approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@Fly-Style Fly-Style left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from SQL side, except what @TomaszGaweda highlighted in the comments.

@hz-devops-test
Copy link

The job Hazelcast-pr-EE-compiler of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file 
--------------------------
---------SUMMARY----------
--------------------------
[ERROR] COMPILATION ERROR : 
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hazelcast-enterprise: Compilation failure: Compilation failure: 
--------------------------
---------ERRORS-----------
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[9,27] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[54,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[61,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[38,0] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[292,40] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,12] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[293,45] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[297,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[408,44] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,16] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[409,49] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/rewrite/RewriteUtil.java:[410,70] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,17] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[304,28] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,18] error: cannot find symbol
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,56] error: invalid method reference
--------------------------
[ERROR] /appdisk/jenkins/jenkins_slave/workspace/Hazelcast-pr-EE-compiler/hazelcast-enterprise/hazelcast-enterprise/src/main/java/com/hazelcast/internal/dynamicconfig/EnterpriseClusterWideConfigurationService.java:[329,29] error: invalid method reference
--------------------------

k-jamroz
k-jamroz approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@k-jamroz k-jamroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL and Jet - LGTM

@frant-hartm frant-hartm merged commit 3dbc936 into hazelcast:master Apr 6, 2023
1 of 2 checks passed
@frant-hartm frant-hartm mentioned this pull request Apr 6, 2023
Merged
srknzl pushed a commit to hazelcast/hazelcast-client-protocol that referenced this pull request Apr 6, 2023
@frant-hartm
Rename data link to data connection [HZ-2231] (#464)
b17d375 
OS PR: hazelcast/hazelcast#24224
EE PR: hazelcast/hazelcast-enterprise#5904
@k-jamroz k-jamroz mentioned this pull request Apr 13, 2023
Merged
3 tasks
k-jamroz added a commit that referenced this pull request Apr 14, 2023
@k-jamroz
Rename data link to data connection in permissions [HZ-2231] (#24273)
ba36217 
Followup for #24224

EE PR: hazelcast/hazelcast-enterprise#5918

Breaking changes (list specific methods/types/messages):
* names of data connections permissions were changes from values in
previous BETA version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldziedziul ldziedziul ldziedziul approved these changes

@TomaszGaweda TomaszGaweda TomaszGaweda approved these changes

@Fly-Style Fly-Style Fly-Style approved these changes

@mdumandag mdumandag mdumandag approved these changes

@k-jamroz k-jamroz k-jamroz approved these changes

Assignees
No one assigned
Labels
Add to Release Notes Module: Jet Issues/PRs for Jet Source: Internal PR or issue was opened by an employee Team: Integration Type: Cleanup
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@frant-hartm @hz-devops-test @ldziedziul @TomaszGaweda @Fly-Style @mdumandag @k-jamroz