Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default cloud coordinator url to viridian API-1796 #23290

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Dec 30, 2022

Changes the default cloud coordinator URL to viridian.

Breaking changes (list specific methods/types/messages):

  • Users who use the default configuration now will connect to viridian instead of hazelcast cloud. Potentially leading them to not being able to connect to the cloud cluster.

I have tried to connect to viridian manually using the following code:

import com.hazelcast.client.HazelcastClient;
import com.hazelcast.client.config.ClientConfig;
import com.hazelcast.config.SSLConfig;
import com.hazelcast.core.HazelcastInstance;
import com.hazelcast.map.IMap;

import java.net.URISyntaxException;
import java.util.Properties;

class MainXX {
    public static void main(String[] args) throws URISyntaxException {
        ClassLoader classLoader = MainXX.class.getClassLoader();
        Properties props = new Properties();
        props.setProperty("javax.net.ssl.keyStore", classLoader.getResource("client.keystore").toURI().getPath());
        props.setProperty("javax.net.ssl.keyStorePassword", "----");
        props.setProperty("javax.net.ssl.trustStore",
                classLoader.getResource("client.truststore").toURI().getPath());
        props.setProperty("javax.net.ssl.trustStorePassword", "-----");
        ClientConfig config = new ClientConfig();
        config.getNetworkConfig().setSSLConfig(new SSLConfig().setEnabled(true).setProperties(props));
        config.getNetworkConfig().getCloudConfig()
                .setDiscoveryToken("-----")
                .setEnabled(true);
        config.setClusterName("----");

        HazelcastInstance client = HazelcastClient.newHazelcastClient(config);

        System.out.println("Connection Successful!");

        IMap<String, String> map = client.getMap("map");
        map.put("key", "value");
        System.out.println(map.get("key"));
    }
}

Checklist:

  • Labels (Team:, Type:, Source:, Module:) and Milestone set
  • Label Add to Release Notes or Not Release Notes content set
  • Request reviewers if possible
  • Send backports/forwardports if fix needs to be applied to past/future releases
  • New public APIs have @Nonnull/@Nullable annotations
  • New public APIs have @since tags in Javadoc

@srknzl srknzl requested a review from emreyigit January 2, 2023 08:48
@srknzl srknzl merged commit 568c860 into hazelcast:master Jan 2, 2023
@mdumandag
Copy link
Contributor

@srknzl @yuce should we backport this as well?

@ihsandemir
Copy link
Contributor

Yes, please do backport.

@srknzl
Copy link
Member Author

srknzl commented Jan 2, 2023

@ihsandemir

Only to 5.2.0, right?

srknzl added a commit to srknzl/hazelcast that referenced this pull request Jan 2, 2023
…23290)

Changes the default cloud coordinator URL to viridian.
Breaking change: Users who use the default configuration
now will connect to viridian instead of hazelcast cloud. 
Potentially leading them to not being ableto connect to the
 cloud cluster.
@ihsandemir
Copy link
Contributor

Yes, to patch release 5.2.1.

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@hz-devops-test
Copy link

The job Hazelcast-pr-builder of your PR failed. (Hazelcast internal details: build log, artifacts).
Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants