Lookup DNS at beginning and cache it #391
Merged
+62
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #386
hickory-dns does cache results but at the beginning, there is no cache, thus DNS Lookups == Number of Concurrent Connections is happening.
This PR makes
oha
perform a lookup DNS at the beginning of a run and makes a cache.I think this solution is more simpler.
@huntharo
Does this solve your issue?