Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup DNS at beginning and cache it #391

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Lookup DNS at beginning and cache it #391

merged 1 commit into from
Jan 30, 2024

Conversation

hatoo
Copy link
Owner

@hatoo hatoo commented Jan 30, 2024

Fix #386

hickory-dns does cache results but at the beginning, there is no cache, thus DNS Lookups == Number of Concurrent Connections is happening.

This PR makes oha perform a lookup DNS at the beginning of a run and makes a cache.

I think this solution is more simpler.

@huntharo
Does this solve your issue?

@huntharo
Copy link
Contributor

Confirmed this fixes the issue:

image

Copy link
Contributor

@huntharo huntharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the fix work, code looks good to me

@hatoo hatoo merged commit 28f6dd6 into master Jan 30, 2024
76 checks passed
@hatoo hatoo deleted the pre-lookup branch February 3, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Lookups == Number of Concurrent Connections
2 participants