Model workflow: pass --disable-documentation to cabal haddock
#109
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmillwood
added a commit
to bmillwood/bluesky-tools
that referenced
this pull request
Jan 8, 2025
For the sake of haskell-actions/setup#109
mihaimaruseac
approved these changes
Jan 8, 2025
bmillwood
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Looks like this has the intended effect: https://github.com/bmillwood/bluesky-tools/actions/runs/12671098086/job/35312123214
ulysses4ever
reviewed
Jan 8, 2025
README.md
Outdated
| ``` | ||
| (Alternatively, the two occurrences of `--disable-documentation` can be changed to `--enable-documentation`, for resolving the external references in the haddockumentation.) |
There was a problem hiding this comment.
I'm afraid "haddockumentation" may be confusing. Gave me a second for sure.
Maybe it can also mention something about possible slowdown due to having to build docs for dependencies.
There was a problem hiding this comment.
I also think parentheses should be dropped (it's too long of a thing to put it into those).
|
@bmillwood and @ulysses4ever , thanks for your reviews! |
|
Looks good, thanks! |
bmillwood
approved these changes
Jan 13, 2025
|
Looks good to me too. Suggested a typo fix but happy either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107.
Asking @bmillwood for a review.