Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Follow on sync updates for 1.16 GA into release/1.16.x #26121

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26114 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


Fixes issue on community where a default 0 date 0001-01-01T00:00:00Z value for the billing start caused incorrect date querying. This regression was introduced when we refactored to use the v1/sys/internal/counters/config for the start time instead of making a query to the license for that info (which would fail on CE)

This PR also hides average sync count when the average is 0

screenshot before fix

image


because there are so many months in the average calculation, the average is a decimal below 1 which rounds to `0` this isn't great UX so hiding in situations like this Screenshot 2024-03-22 at 12 55 18 PM

enterprise passed ✅


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/follow-on-sync-updates/neatly-verified-grubworm branch from 6b413bf to 338a12f Compare March 22, 2024 20:49
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 22, 2024
@hellobontempo hellobontempo added this to the 1.16.0 milestone Mar 22, 2024
Copy link

Build Results:
All builds succeeded! ✅

@hellobontempo hellobontempo enabled auto-merge (squash) March 22, 2024 20:57
Copy link

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit bc9c844 into release/1.16.x Mar 22, 2024
24 of 25 checks passed
@hellobontempo hellobontempo deleted the backport/ui/follow-on-sync-updates/neatly-verified-grubworm branch March 22, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants