Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Docs/vault 23837/sync doc update into release/1.16.x #26058

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Backport of Docs/vault 23837/sync doc update into release/1.16.x #26058

merged 4 commits into from
Mar 22, 2024

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25433 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@maxcoulombe
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

  • Documented the name template feature
  • Documented the custom tag feature
  • Documented the granularity feature
  • Added the queue_capacity field on the config endpoint
  • Documented the urge option on deletes
Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 20, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 20, 2024
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@maxcoulombe @mickael-hc
Docs/vault 23837/sync doc update (#25433)
8803e5a 
* + documented the new sync API options
@mickael-hc mickael-hc force-pushed the backport/docs/vault-23837/sync-doc-update/jolly-clear-racer branch from b757ffa to 8803e5a Compare March 20, 2024 18:09
@maxcoulombe
* cherry-pick
782b973 
* address review comments

* move statuses into a table for consistency
* fix merge conflicts
@maxcoulombe maxcoulombe added this to the 1.16.0 milestone Mar 22, 2024
@maxcoulombe maxcoulombe marked this pull request as ready for review March 22, 2024 20:12
@maxcoulombe maxcoulombe requested a review from a team as a code owner March 22, 2024 20:12
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@maxcoulombe maxcoulombe merged commit 6a694d0 into release/1.16.x Mar 22, 2024
23 of 24 checks passed
@maxcoulombe maxcoulombe deleted the backport/docs/vault-23837/sync-doc-update/jolly-clear-racer branch March 22, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcoulombe maxcoulombe maxcoulombe approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hc-github-team-secure-vault-core @hashicorp-cla @maxcoulombe @mickael-hc