Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Reduce number of places where go version is set into release/1.12.x #18099

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17762 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Now we have only .go_version and @executors.yml. Also add a GH action to ensure those two are kept in sync.

Details:

  • go_test accepted a go_image parameter but nothing ever specified it, we were just relying on the default, so now instead we'll use the GO_IMAGE environment variable
  • reworked @executors to look more like the ent version of the file; ensure that GO_IMAGE environment variable is set everywhere; and set the version once in an anchor, in references.environment.GO_IMAGE
  • add a .go-version file in the root of the tree, as some ecosystem repos are doing already, and change the Makefile to use that file instead of hard-coding it; this allows us to programatically determine the current version the repo wants without having to parse the Makefile or invoke make
  • remove references to specific Go version from README; we can assume that most people will install the latest Go version, and the Makefile will protect against those who don't
  • remove references to specific Go version in dockerfiles; the Makefile target that uses them already passes in the Go version anyway

Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

Reduce go version references to two: .go_version and @executors.yml.
@ncabatoff ncabatoff force-pushed the backport/reduce-go-version-places-oss/reliably-wondrous-marmoset branch from cd051a2 to 534b49f Compare November 23, 2022 15:12
@ncabatoff ncabatoff marked this pull request as ready for review November 23, 2022 15:24
@ncabatoff ncabatoff merged commit fbbc3be into release/1.12.x Nov 23, 2022
@ncabatoff ncabatoff deleted the backport/reduce-go-version-places-oss/reliably-wondrous-marmoset branch November 23, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants