Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of places where go version is set #17762

Merged
merged 5 commits into from Nov 1, 2022

Conversation

ncabatoff
Copy link
Collaborator

@ncabatoff ncabatoff commented Nov 1, 2022

Now we have only .go_version and @executors.yml. Also add a GH action to ensure those two are kept in sync.

Details:

  • go_test accepted a go_image parameter but nothing ever specified it, we were just relying on the default, so now instead we'll use the GO_IMAGE environment variable
  • reworked @executors to look more like the ent version of the file; ensure that GO_IMAGE environment variable is set everywhere; and set the version once in an anchor, in references.environment.GO_IMAGE
  • add a .go-version file in the root of the tree, as some ecosystem repos are doing already, and change the Makefile to use that file instead of hard-coding it; this allows us to programatically determine the current version the repo wants without having to parse the Makefile or invoke make
  • remove references to specific Go version from README; we can assume that most people will install the latest Go version, and the Makefile will protect against those who don't
  • remove references to specific Go version in dockerfiles; the Makefile target that uses them already passes in the Go version anyway

Copy link
Collaborator

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some optional suggestions on the action, but this seems like a nice improvement 👍

.github/workflows/goversion-checker.yml Outdated Show resolved Hide resolved
.github/workflows/goversion-checker.yml Outdated Show resolved Hide resolved
.github/workflows/goversion-checker.yml Outdated Show resolved Hide resolved
.github/workflows/goversion-checker.yml Show resolved Hide resolved
@ncabatoff ncabatoff merged commit 81a563d into main Nov 1, 2022
@ncabatoff ncabatoff deleted the reduce-go-version-places-oss branch November 1, 2022 19:37
ncabatoff added a commit that referenced this pull request Nov 23, 2022
Reduce go version references to two: .go_version and @executors.yml.
ncabatoff added a commit that referenced this pull request Nov 23, 2022
Reduce go version references to two: .go_version and @executors.yml.
ncabatoff added a commit that referenced this pull request Nov 23, 2022
Reduce go version references to two: .go_version and @executors.yml.
ncabatoff pushed a commit that referenced this pull request Nov 23, 2022
Reduce go version references to two: .go_version and @executors.yml.
ncabatoff pushed a commit that referenced this pull request Nov 23, 2022
Reduce go version references to two: .go_version and @executors.yml.
jayant07-yb pushed a commit to jayant07-yb/hashicorp-vault-integrations that referenced this pull request Mar 15, 2023
Reduce go version references to two: .go_version and @executors.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants