Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes in /sys/managed-keys #14377

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

divyapola5
Copy link
Contributor

With the testing done as part of VAULT-4246, it was noticed that /sys/managed-keys documentation needs some updates.
This PR addresses those changes. See VAULT-5320 for more details.

@divyapola5 divyapola5 requested a review from a team March 4, 2022 17:35
@vercel vercel bot temporarily deployed to Preview – vault March 14, 2022 17:23 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 14, 2022 17:23 Inactive
Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@divyapola5 divyapola5 merged commit 0516641 into main Mar 18, 2022
@divyapola5 divyapola5 added this to the 1.10 milestone Mar 21, 2022
divyapola5 added a commit that referenced this pull request Mar 21, 2022
* update sample request in create managed keys

* Update documentation for curve param

* Add period at end of sentence

* Update key_bits documentation for aws and azure
divyapola5 added a commit that referenced this pull request Mar 21, 2022
* update sample request in create managed keys

* Update documentation for curve param

* Add period at end of sentence

* Update key_bits documentation for aws and azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants