Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCredentials Bug fix #13336

Merged
merged 2 commits into from
Dec 3, 2021
Merged

GetCredentials Bug fix #13336

merged 2 commits into from
Dec 3, 2021

Conversation

Monkeychip
Copy link
Contributor

A regression bug caused by a required property added to the GetCredentialsCard component that was not added to a previous instance of the component.

Will backport to 1.9.x

@Monkeychip Monkeychip added backport bug Used to indicate a potential bug pr/no-changelog ui labels Dec 3, 2021
@Monkeychip Monkeychip added this to the 1.9.1 milestone Dec 3, 2021
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a test! 😍

@Monkeychip Monkeychip merged commit 8f92d43 into main Dec 3, 2021
@Monkeychip Monkeychip deleted the ui/get-creds-bug-fix branch December 3, 2021 22:00
Monkeychip added a commit that referenced this pull request Dec 3, 2021
* the fix

* test coverage
Monkeychip added a commit that referenced this pull request Dec 3, 2021
* the fix

* test coverage
qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
* the fix

* test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Credentials button is disabled after upgrading to 1.9.0-ent
2 participants