Identity: check NextSigningKey existence during key rotation #13298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
Nov 29, 2021
austingebauer
approved these changes
Nov 29, 2021
fairclothjm
added a commit
that referenced
this pull request
Nov 29, 2021
* oidc: fix key rotation panic * refactor and update unit tests * add changelog
fairclothjm
added a commit
that referenced
this pull request
Nov 29, 2021
* oidc: fix key rotation panic * refactor and update unit tests * add changelog
fairclothjm
added a commit
that referenced
this pull request
Nov 29, 2021
qk4l
pushed a commit
to qk4l/vault
that referenced
this pull request
Feb 4, 2022
…rp#13298) * oidc: fix key rotation panic * refactor and update unit tests * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a panic in the OIDC key rotation due to a missing nil check.
Fixes: #13223
Background
Vault 1.9 introduced a feature to pre-publish signing keys. When keys are generated in Vault 1.8 and rotated with Vault 1.9 a panic will occur due to a missing nil check.
To reproduce the issue: