Retry core.getIDToken for JWT Auth Method #574
Merged
+79
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
reviewed
Mar 3, 2025
| @@ -35,7 +37,10 @@ async function retrieveToken(method, client) { | |||
| const githubAudience = core.getInput('jwtGithubAudience', { required: false }); | |||
|
|
|||
| if (!privateKey) { | |||
| jwt = await core.getIDToken(githubAudience) | |||
| jwt = await retryAsyncFunction(retries, retries_delay, core.getIDToken, githubAudience) | |||
| .then((result) => { | |||
There was a problem hiding this comment.
@aefuente Should we catch any errors here?
There was a problem hiding this comment.
@fairclothjm The error that gets thrown would be core.getIDToken Error. Its possible we could return a more explicit/generic message "failed to get ID Token from Github" or something like that, but the error should still be thrown at this step. This error isn't caught by action.js and should terminate the run in error status.
There was a problem hiding this comment.
Thanks, that was my assumption as well but wanted to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core.getIDToken intermittently fails for both cloud hosted and on prem runners. This causes entire workflows to fail.
Adds a generic async retry function. Adds 5 retries with 3 seconds of delay between core.getIDToken calls.
Closes #525