Fix crash when nested data blocks are mixed with the import command #33578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when the
terraform import
command is used against configuration that has a nested data block defined within a check block.Essentially, the nested data block still tries to report its checkable status during an import operation. This results in the checks system panicking as it is not expecting that kind of check to be reported.
The fix in this case is just to make the full check block also execute during an import operation. Note, that this behaviour matches the behaviour of other checkable objects. Resource pre and post conditions still execute during the validate operation, they just report warnings instead of errors. As check blocks already only report warnings, making all checkable objects consistent in this case is as simple as turning on check blocks during import.
Fixes #33572
Target Release
1.5.4
Draft CHANGELOG entry
BUG FIXES
check
blocks: Fixes crash when nested data sources are within configuration targeted by theterraform import
command.check
blocks: Check blocks now operate in line with other checkable objects by also executing during import operations.