Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest diffs for OCI charts #1326

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

mmckeen
Copy link
Contributor

@mmckeen mmckeen commented Feb 7, 2024

Description

Fixes #1325.

The OCI registry client wasn't properly initialized in this code path for OCI charts.

This also changes error handling so failures to fetch the chart aren't silent in the future.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

`provider`: Fix manifest diff rendering for OCI charts.

References

#1325

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Sorry, something went wrong.

@mmckeen mmckeen requested a review from a team as a code owner February 7, 2024 16:14
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 7, 2024

CLA assistant check
All committers have signed the CLA.

@sheneska
Copy link
Contributor

sheneska commented Mar 1, 2024

Hi @mmckeen, Thank you for your interest in contributing to this provider. I would like to approve and merge your change, however, two things are missing:

Please let me know once this is done & feel free to ask any questions.

mmckeen added 2 commits March 11, 2024 09:21

Verified

This commit was signed with the committer’s verified signature.
MichaelDeBoey Michaël De Boey
@mmckeen mmckeen force-pushed the mmckeen-fixocimanifestdiffs branch from a2b30b3 to 10740b3 Compare March 11, 2024 16:28
@mmckeen
Copy link
Contributor Author

mmckeen commented Mar 11, 2024

Hey @sheneska 👋

I went ahead and signed the CLA and added a CHANGELOG entry.

Let me know if there's anything else for this 🙇.

Thank you!

@mmckeen mmckeen requested a review from sheneska March 12, 2024 15:48
@sheneska sheneska merged commit d533734 into hashicorp:main Mar 14, 2024
17 checks passed
@sbeginCoveo
Copy link

@sheneska What's the release cycle like for the helm provider?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm manifest diffs aren't generated for OCI charts
6 participants