.changelog/8011.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+spanner: added `enable_drop_protection` to `google_spanner_database`
+```

.changelog/8124.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+`google_dataplex_task`
+```

.changelog/8164.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: added `reconcile_connections` for `google_compute_service_attachment`.
+```

.changelog/8165.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed wrongly trigger recreation on changes of `enforce_on_key_configs` on `google_compute_security_policy`
+```

.changelog/8208.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+Compute: added `security_policy` field to `google_compute_region_backend_service` resource(beta)
+```

.changelog/8263.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+composer: added support for updating `resilience_mode` in `google_composer_environment`
+```

.changelog/8290.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+cloudrunv2: added field `custom_audiences` to resource `google_cloud_run_v2_service `
+```

.changelog/8323.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+container: added `allow_net_admin` field to `google_container_cluster` resource
+```

.changelog/8349.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8359.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+cloud_tasks: suppressed time-unit permadiffs on `google_cloud_tasks_queue` min and max backoff settings
+```

.changelog/8363.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+healthcare: added `last_updated_partition_config` field to `google_healthcare_fhir_store` resource
+```

.changelog/8365.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8370.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: replaced `ipv6CidrRange` with `internalIpv6Prefix` to `Subnetwork` resource
+```

.changelog/8374.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8383.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+artifactregistry: fixed reading back maven_config state in `google_artifact_registry_repository`
+```

.changelog/8385.txt

@@ -0,0 +1,3 @@
+```release-note: enhancement
+container: added multi-NIC network for GKE cluster and node pool.
+```

.changelog/8388.txt

@@ -0,0 +1,2 @@
+```release-note:none
+```

.changelog/8390.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+network_services: removing required flags from `scope` field in `google_network_services_gateway` resource
+```

.changelog/8394.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8398.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8400.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8401.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8407.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8410.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+cloud-run: added `status.traffic` output fields to `google_cloud_run_service` resource 
+```

.changelog/8411.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+container : added `gcs_fuse_csi_driver_config` field to `addons_config` in `google_container_cluster` resource.
+```

.changelog/8423.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8424.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8425.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8426.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8427.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8428.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8430.txt

@@ -0,0 +1,9 @@
+```release-note:new-resource
+google_iap_web_region_backend_service_iam_policy
+```
+```release-note:new-resource
+google_iap_web_region_backend_service_iam_binding
+```
+```release-note:new-resource
+google_iap_web_region_backend_service_iam_member
+```

.changelog/8435.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+cloudrun: fixed the bug where default system labels set in `service.spec.template.metadata.labels` were treated as a diff.
+```

.changelog/8438.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

.changelog/8442.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+container: allowed user to set up to 20 maintenance exclusions for `google_container_cluster` resource
+```

.changelog/8443.txt

@@ -0,0 +1,4 @@
+```release-note:new-resource
+`google_compute_region_ssl_policy` (GA)
+
+```

.changelog/8448.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+monitoring: added `condition_prometheus_query_language` field to `google_monitoring_alert_policy` resource
+```

.changelog/8450.txt

@@ -0,0 +1,3 @@
+```release-note:note
+docs: Update documentation about `destination` in the resource `google_logging_project_sink`
+```

.changelog/8454.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+monitoring: fixed an issue in `google_monitoring_monitored_project` where project numbers were not accepted for `name`
+```

.changelog/8456.txt

@@ -0,0 +1,6 @@
+```release-note:bug
+vpcaccess: reverted new behaviour introduced by resource `google_vpc_access_connector` in `4.75.0`. `min_throughput` and `max_throughput` fields lost their default value, and customers could not make deployment due to that change.
+```
+```release-note:note
+vpcaccess: reverted the ability to update the number of instances for resource `google_vpc_access_connector`
+```

.changelog/8457.txt

@@ -0,0 +1,3 @@
+```release-note:none
+Documentation change only
+```

.changelog/8479.txt

@@ -0,0 +1,2 @@
+```release-note: none
+```

.github/workflows/self-service-labeler.yml

@@ -0,0 +1,40 @@
+name: Issue Opened Self-Service Labeler
+
+on:
+  issues:
+    types: [opened]
+
+jobs:
+  add-labels:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+    - name: Checkout magic modules
+      uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
+      with:
+        repository: GoogleCloudPlatform/magic-modules
+        ref: main
+        path: magic-modules
+    - name: Setup go
+      uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 # v4.0.0
+      with:
+        go-version: '>=1.19.0'
+    - name: Pick labels
+      id: pick_labels
+      env:
+        ISSUE_BODY: ${{ github.event.issue.body }}
+      run: |
+        cd magic-modules/tools/issue-labeler
+        echo "labels=$(go run .)" >> $GITHUB_OUTPUT
+    - name: Apply labels
+      uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1
+      if: ${{ steps.pick_labels.outputs.labels != '' }}
+      with:
+        script: |
+          github.rest.issues.addLabels({
+            issue_number: context.issue.number,
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            labels: ${{ steps.pick_labels.outputs.labels }}
+          })

.teamcity/components/build_config_package.kt

@@ -1,21 +1,25 @@
 // this file is copied from mmv1, any changes made here will be overwritten
 
 import jetbrains.buildServer.configs.kotlin.*
+import jetbrains.buildServer.configs.kotlin.AbsoluteId
 
-class packageDetails(name: String, displayName: String, environment: String) {
+class packageDetails(name: String, displayName: String, environment: String, branchRef: String) {
     val packageName = name
     val displayName = displayName
     val environment = environment
+    val branchRef = branchRef
 
-    fun buildConfiguration(providerName : String, path : String, nightlyTestsEnabled: Boolean, startHour: Int, parallelism: Int, daysOfWeek: String, daysOfMonth: String) : BuildType {
+    // buildConfiguration returns a BuildType for a service package
+    // For BuildType docs, see https://teamcity.jetbrains.com/app/dsl-documentation/root/build-type/index.html
+    fun buildConfiguration(providerName : String, path : String, manualVcsRoot: AbsoluteId, nightlyTestsEnabled: Boolean, startHour: Int, parallelism: Int, daysOfWeek: String, daysOfMonth: String) : BuildType {
         return BuildType {
             // TC needs a consistent ID for dynamically generated packages
             id(uniqueID(providerName))
 
             name = "%s - Acceptance Tests".format(displayName)
 
             vcs {
-                root(providerRepository)
+                root(rootId = manualVcsRoot)
                 cleanCheckout = true
             }
 
@@ -49,12 +53,18 @@ class packageDetails(name: String, displayName: String, environment: String) {
             }
 
             triggers {
-                RunNightly(nightlyTestsEnabled, startHour, daysOfWeek, daysOfMonth)
+                RunNightly(nightlyTestsEnabled, startHour, daysOfWeek, daysOfMonth, branchRef)
             }
         }
     }
 
     fun uniqueID(provider : String) : String {
-        return "%s_SERVICE_%s_%s".format(provider.replace("-", "").toUpperCase(), environment.toUpperCase(), packageName.toUpperCase())
+        // Replacing chars can be necessary, due to limitations on IDs
+        // "ID should start with a latin letter and contain only latin letters, digits and underscores (at most 225 characters)." 
+        var pv = provider.replace("-", "").toUpperCase()
+        var env = environment.toUpperCase().replace("-", "").replace(".", "").toUpperCase()
+        var pkg = packageName.toUpperCase()
+
+        return "%s_SERVICE_%s_%s".format(pv, env, pkg)
     }
 }

.teamcity/components/build_google.kt

@@ -19,6 +19,9 @@ class ClientConfiguration(var custId: String,
                           val identityUser : String ) {
 }
 
+// ParametrizedWithType.ConfigureGoogleSpecificTestParameters allows build configs to be created
+// with the environment variables needed to configure the provider and/or configure test code.
+// Extension of ParametrizedWithType. For docs, see https://teamcity.jetbrains.com/app/dsl-documentation/root/parametrized-with-type/index.html
 fun ParametrizedWithType.ConfigureGoogleSpecificTestParameters(config: ClientConfiguration) {
     hiddenPasswordVariable("env.GOOGLE_CUST_ID", config.custId, "The ID of the Google Identity Customer")
     hiddenPasswordVariable("env.GOOGLE_ORG", config.org, "The Google Organization Id")

.teamcity/components/generated/build_components.kt

@@ -12,6 +12,15 @@ import jetbrains.buildServer.configs.kotlin.triggers.schedule
 //
 // Until that changes, we'll continue to use `teamcity-go-test` to run
 // each test individually
+
+// NOTE: this file includes Extensions of Kotlin DSL classes
+// See
+// - BuildFeatures           https://teamcity.jetbrains.com/app/dsl-documentation/root/build-features/index.html
+// - BuildSteps              https://teamcity.jetbrains.com/app/dsl-documentation/root/build-steps/index.html
+// - ParametrizedWithType    https://teamcity.jetbrains.com/app/dsl-documentation/root/parametrized-with-type/index.html
+// - Triggers                https://teamcity.jetbrains.com/app/dsl-documentation/root/triggers/index.html
+
+
 const val useTeamCityGoTest = false
 
 fun BuildFeatures.Golang() {
@@ -120,10 +129,12 @@ fun ParametrizedWithType.hiddenPasswordVariable(name: String, value: String, des
     password(name, value, "", description, ParameterDisplay.HIDDEN)
 }
 
-fun Triggers.RunNightly(nightlyTestsEnabled: Boolean, startHour: Int, daysOfWeek: String, daysOfMonth: String) {
+fun Triggers.RunNightly(nightlyTestsEnabled: Boolean, startHour: Int, daysOfWeek: String, daysOfMonth: String, branchRef: String) {
+    val filter = "+:" + branchRef // e.g. "+:refs/heads/main"
+
     schedule{
         enabled = nightlyTestsEnabled
-        branchFilter = "+:refs/heads/main"
+        branchFilter = filter
 
         schedulingPolicy = cron {
             hours = startHour.toString()

.teamcity/components/generated/project.kt

@@ -2,32 +2,37 @@
 
 import jetbrains.buildServer.configs.kotlin.BuildType
 import jetbrains.buildServer.configs.kotlin.Project
+import jetbrains.buildServer.configs.kotlin.AbsoluteId
 
 const val providerName = "google"
 
-fun Google(environment: String, configuration : ClientConfiguration) : Project {
+// Google returns an instance of Project,
+// which has multiple build configurations defined within it.
+// See https://teamcity.jetbrains.com/app/dsl-documentation/root/project/index.html
+fun Google(environment: String, manualVcsRoot: AbsoluteId, branchRef: String, configuration: ClientConfiguration) : Project {
     return Project{
-        vcsRoot(providerRepository)
 
-        var buildConfigs = buildConfigurationsForPackages(packages, providerName, "google", environment, configuration)
+        var buildConfigs = buildConfigurationsForPackages(packages, providerName, "google", environment, manualVcsRoot, branchRef, configuration)
         buildConfigs.forEach { buildConfiguration ->
             buildType(buildConfiguration)
         }
     }
 }
 
-fun buildConfigurationsForPackages(packages: Map<String, String>, providerName : String, path : String, environment: String, config : ClientConfiguration): List<BuildType> {
+fun buildConfigurationsForPackages(packages: Map<String, String>, providerName : String, path : String, environment: String, manualVcsRoot: AbsoluteId, branchRef: String, config: ClientConfiguration): List<BuildType> {
     var list = ArrayList<BuildType>()
 
     packages.forEach { (packageName, displayName) ->
         if (packageName == "services") {
-            var serviceList = buildConfigurationsForPackages(services, providerName, path+"/"+packageName, environment, config)
+            // `services` is a folder containing packages, not a package itself; call buildConfigurationsForPackages to iterate through directories found within `services`
+            var serviceList = buildConfigurationsForPackages(services, providerName, path+"/"+packageName, environment, manualVcsRoot, branchRef, config)
             list.addAll(serviceList)
         } else {
-            var defaultTestConfig = testConfiguration()
+            // other folders assumed to be packages
+            var testConfig = testConfiguration(environment)
 
-            var pkg = packageDetails(packageName, displayName, environment)
-            var buildConfig = pkg.buildConfiguration(providerName, path, true, defaultTestConfig.startHour, defaultTestConfig.parallelism, defaultTestConfig.daysOfWeek, defaultTestConfig.daysOfMonth)
+            var pkg = packageDetails(packageName, displayName, environment, branchRef)
+            var buildConfig = pkg.buildConfiguration(providerName, path, manualVcsRoot, true, testConfig.startHour, testConfig.parallelism, testConfig.daysOfWeek, testConfig.daysOfMonth)
 
             buildConfig.params.ConfigureGoogleSpecificTestParameters(config)
 
@@ -38,9 +43,23 @@ fun buildConfigurationsForPackages(packages: Map<String, String>, providerName :
     return list
 }
 
-class testConfiguration(parallelism: Int = defaultParallelism, startHour: Int = defaultStartHour, daysOfWeek: String = defaultDaysOfWeek, daysOfMonth: String = defaultDaysOfMonth) {
+class testConfiguration(environment: String, parallelism: Int = defaultParallelism, startHour: Int = defaultStartHour, daysOfWeek: String = defaultDaysOfWeek, daysOfMonth: String = defaultDaysOfMonth) {
+
+    // Default values are present if init doesn't change them
     var parallelism = parallelism
     var startHour = startHour
     var daysOfWeek = daysOfWeek
     var daysOfMonth = daysOfMonth
+
+    init {
+        // If the environment parameter is set to the value of MAJOR_RELEASE_TESTING, 
+        // change the days of week to the day for v5.0.0 feature branch testing
+        if (environment == MAJOR_RELEASE_TESTING) {
+            this.parallelism = parallelism
+            this.startHour = startHour
+            this.daysOfWeek = "4" // Thursday for GA
+            this.daysOfMonth = daysOfMonth
+        }
+    }
+
 }