Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: refactoring azurerm_blob_inventory_policy to use hashicorp/go-azure-sdk #25268

Merged
merged 4 commits into from
Mar 20, 2024
Merged

storage: refactoring azurerm_blob_inventory_policy to use hashicorp/go-azure-sdk #25268

merged 4 commits into from
Mar 20, 2024

Conversation

tombuildsstuff
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR refactors azurerm_blob_inventory_policy over to using hashicorp/go-azure-sdk rather than Azure/azure-sdk-for-go - and updates the Resource ID to use the Storage Account ID since this is 1:1 with the Storage Account.

@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 15, 2024
@tombuildsstuff tombuildsstuff requested a review from a team March 15, 2024 11:40
@tombuildsstuff tombuildsstuff marked this pull request as ready for review March 15, 2024 14:55
katbyte
katbyte approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛈️

@tombuildsstuff tombuildsstuff merged commit a64df42 into main Mar 20, 2024
30 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/storage-blob-inventory-policy branch March 20, 2024 10:46
tombuildsstuff added a commit that referenced this pull request Mar 20, 2024
@tombuildsstuff
updating to include #25268
d5af7db
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
refactor service/storage size/XL state-migration
Projects
None yet
Milestone
v3.97.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tombuildsstuff @katbyte