azurerm_healthcare_service - support for identity and configuration_export_storage_account_name properties

[Khayoann2]

I was unable to fully set up a new healthcare service project because some mandatory information needed to be provided. So I thought to myself, let’s try to contribute.

To be honest, i'm more a devops engineer than a developer so be aware to contribute and challenge me if i miss something...

[cedrox]

Thanks for tackling this. Do we have an ETA for the availability ?

[Khayoann2]

Thanks for tackling this. Do we have an ETA for the availability ?

Hope that a maintainer will take my PR soon 👌🤞

[katbyte]

Looks like there is a test failure:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccHealthCareServiceDataSource_basic
=== PAUSE TestAccHealthCareServiceDataSource_basic
=== CONT  TestAccHealthCareServiceDataSource_basic

------- Stderr: -------
panic: identity: '': source data must be an array or slice, got struct

goroutine 412 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc00287f280, {0x8a58322, 0x8}, {0x8036140, 0xc003abf620})
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource_data.go:233 +0x2b5
github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare.resourceHealthcareServiceRead(0xc00287f280, {0x7a6be80?, 0xc004926480?})

[Khayoann2]

Looks like there is a test failure:

Test ended in panic.

------- Stdout: -------
=== RUN   TestAccHealthCareServiceDataSource_basic
=== PAUSE TestAccHealthCareServiceDataSource_basic
=== CONT  TestAccHealthCareServiceDataSource_basic

------- Stderr: -------
panic: identity: '': source data must be an array or slice, got struct

goroutine 412 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc00287f280, {0x8a58322, 0x8}, {0x8036140, 0xc003abf620})
	/opt/teamcity-agent/work/3337027aeff310bf/vendor/github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema/resource_data.go:233 +0x2b5
github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare.resourceHealthcareServiceRead(0xc00287f280, {0x7a6be80?, 0xc004926480?})

Fix has been pushed and this issue is now solved.
Thank you @katbyte

[Khayoann2]

I detected another issue. i will push another fix

[Khayoann2]

Now everything is green on my side
@katbyte

[Khayoann2]

@katbyte Could you take a look, please ? 👍

[Khayoann2]

I don't know what i can do to make it merged 😢
Is there anything remaining on my side ? because i'm a little bit confused ...

[katbyte]

Thanks @Khayoann2 ! LGTM 🏥

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.